Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing To Do list: part 2 #8

Merged
merged 7 commits into from
Jul 28, 2023
Merged

Testing To Do list: part 2 #8

merged 7 commits into from
Jul 28, 2023

Conversation

Uzair-Manzoor
Copy link
Owner

@Uzair-Manzoor Uzair-Manzoor commented Jul 28, 2023

This pull request has been created against the new implementations mentioned below:

  • tested the functions responsible for the status and content updates
  • Used jest framework for testing.
  • Created test files ([..].test.js) for files containing the following functions:
    • a function for editing the task description.
    • a function for updating an item's 'completed' status.
    • the "Clear all completed" function.
  • Used the mock storage object to mock the localStorage updates.
  • Mocked the HTML elements to test DOM manipulation functions.

Copy link

@V-Blaze V-Blaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Uzair-Manzoor, @samuelkinyanjui

Approved 🍏 🟢

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
green-lantern-ok

Highlights

  • Test covers Edit, Clear-completed, and toggle status✔✔
  • Tests are passing ✔️
  • Correct Github flow ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Uzair-Manzoor Uzair-Manzoor merged commit c78e73c into main Jul 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants