Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api.add_variable() add parameter keyword #304

Merged
merged 5 commits into from
Oct 20, 2023
Merged

Conversation

AlexDo1
Copy link
Collaborator

@AlexDo1 AlexDo1 commented Oct 20, 2023

Adds the optional parameter keyword to api.add_variable() to make it possible to link a variable to a keyword when a new varible is added.

Closes #303

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #304 (d993a47) into main (ca7b775) will increase coverage by 0.33%.
The diff coverage is 27.27%.

❗ Current head d993a47 differs from pull request most recent head 824d9ae. Consider uploading reports for the commit 824d9ae to get more accurate results

@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   64.04%   64.38%   +0.33%     
==========================================
  Files          75       75              
  Lines        3969     3931      -38     
==========================================
- Hits         2542     2531      -11     
+ Misses       1427     1400      -27     
Flag Coverage Δ
e2e 64.38% <27.27%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
metacatalog/api/find.py 63.78% <33.33%> (-0.35%) ⬇️
metacatalog/api/add.py 50.45% <25.00%> (-1.21%) ⬇️

... and 2 files with indirect coverage changes

@AlexDo1 AlexDo1 marked this pull request as ready for review October 20, 2023 12:43
@AlexDo1 AlexDo1 self-assigned this Oct 20, 2023
@AlexDo1 AlexDo1 added the enhancement New feature or request label Oct 20, 2023
Copy link
Member

@mmaelicke mmaelicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve, but I have a few minor questions

metacatalog/api/add.py Show resolved Hide resolved
metacatalog/api/find.py Outdated Show resolved Hide resolved
@AlexDo1 AlexDo1 added this pull request to the merge queue Oct 20, 2023
Merged via the queue into main with commit 60cb024 Oct 20, 2023
15 checks passed
@AlexDo1 AlexDo1 deleted the add_variable_keyword branch October 20, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api.add_variable() add parameter keyword
2 participants