Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename Mascots enum to Mascot #556

Merged
merged 4 commits into from
Jun 6, 2024
Merged

refactor: rename Mascots enum to Mascot #556

merged 4 commits into from
Jun 6, 2024

Conversation

jsgalarraga
Copy link
Member

Description

Renaming Mascots to Mascot to be singular as is the convention for enums.

Screenshots/Video

Not applicable

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Monday.com Item IDs

6409876548

@jsgalarraga jsgalarraga self-assigned this Jun 5, 2024
marwfair
marwfair requested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@marwfair marwfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just left a few suggestions.

api/packages/game_domain/lib/src/models/mascots.dart Outdated Show resolved Hide resolved
api/packages/game_domain/lib/src/models/mascots.dart Outdated Show resolved Hide resolved
api/packages/game_domain/lib/src/models/mascots.dart Outdated Show resolved Hide resolved
marwfair
marwfair approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@marwfair marwfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsgalarraga jsgalarraga merged commit a753457 into main Jun 6, 2024
10 checks passed
@jsgalarraga jsgalarraga deleted the refactor/mascots-enum branch June 6, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marwfair marwfair marwfair approved these changes

@B0berman B0berman Awaiting requested review from B0berman B0berman is a code owner

@AyadLaouissi AyadLaouissi Awaiting requested review from AyadLaouissi AyadLaouissi is a code owner

@alestiago alestiago Awaiting requested review from alestiago alestiago is a code owner

Assignees

@jsgalarraga jsgalarraga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsgalarraga @marwfair