Skip to content

Commit

Permalink
fix test tag generation corner case when last chain of statement in a…
Browse files Browse the repository at this point in the history 
… block is overwritten
  • Loading branch information
@0xera
0xera committed Jan 31, 2024
1 parent c8c69ee commit ffda833
Showing 1 changed file with 104 additions and 41 deletions.
145 changes: 104 additions & 41 deletions .../plugin/src/main/kotlin/com/vk/compiler/plugin/compose/test/tag/applier/TestTagApplier.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@ internal class TestTagApplier(
private val pluginContext: IrPluginContext
) : IrElementTransformerVoid() {

private val applyTagFunction by lazy {
pluginContext.referenceFunctions(applyTagCallableId).firstOrNull()?.owner?.symbol
}
private val transformedCalls = mutableSetOf<IrCall>()

private val modifierObjectClass by lazy {
pluginContext.referenceClass(modifierObjectClassId)
Expand All @@ -48,6 +46,10 @@ internal class TestTagApplier(
pluginContext.referenceFunctions(thenFuncCallableId).firstOrNull()?.owner?.symbol
}

private val applyTagFunction by lazy {
pluginContext.referenceFunctions(applyTagCallableId).firstOrNull()?.owner?.symbol
}

private val functionsStack = mutableListOf<IrFunction>()
private val filesStack = mutableListOf<IrFile>()

Expand All @@ -65,15 +67,23 @@ internal class TestTagApplier(
return result
}

override fun visitCall(expression: IrCall): IrExpression {
override fun visitCall(expression: IrCall): IrExpression =
super.visitCall(expression.applyTestTagToModifier())


private fun IrCall.applyTestTagToModifier(): IrCall {
val applyTagFunction = applyTagFunction
val lastFile = filesStack.lastOrNull()
val lastFunction = functionsStack.lastOrNull()?.searchNotAnonymous()

if (applyTagFunction != null && lastFile != null && lastFunction != null && expression.symbol.owner.isComposable()) {
expression.transformModifierArguments(applyTagFunction, lastFile, lastFunction)
}
return super.visitCall(expression)
if (applyTagFunction == null || lastFile == null || lastFunction == null) return this

if (!symbol.owner.isComposable() || this in transformedCalls) return this

transformedCalls += this

return transformModifierArguments(applyTagFunction, lastFile, lastFunction)

}

private fun IrCall.transformModifierArguments(
Expand All @@ -82,30 +92,32 @@ internal class TestTagApplier(
lastFunction: IrFunction
): IrCall {

for(index in 0 until valueArgumentsCount) {
repeat(valueArgumentsCount) { index ->
val parameter = symbol.owner.valueParameters[index]
val argumentExpression = retrieveArgumentExpression(parameter, getValueArgument(index))

if (argumentExpression == null || argumentExpression.containsModifierWithTestTag() || parameter.isVararg || !parameter.isMainComposeModifier()) {
continue
}
if (argumentExpression?.containsModifierWithTestTag() == false && !parameter.isVararg && parameter.isMainComposeModifier()) {

val modifiedArgumentExpression = modifyExpressionForTestTag(
parameter,
argumentExpression,
createTag(this, lastFile, lastFunction),
applyTagFunction
)
modifiedArgumentExpression?.let { putValueArgument(index, it) }
val modifiedArgumentExpression = modifyExpressionForTestTag(
argumentExpression,
parameter,
applyTagFunction,
createTag(this, lastFile, lastFunction)
)
if (modifiedArgumentExpression != null) putValueArgument(
index,
modifiedArgumentExpression
)
}
}
return this
}

private fun modifyExpressionForTestTag(
parameter: IrValueParameter,
argumentExpression: IrExpression,
tag: String,
applyTagFunction: IrSimpleFunctionSymbol
parameter: IrValueParameter,
applyTagFunction: IrSimpleFunctionSymbol,
tag: String
): IrExpression? {

// Column() -> Column(<default-value>.applyTestTag(tag))
Expand All @@ -119,13 +131,19 @@ internal class TestTagApplier(
// val tmp_modifier: Modifier.Object = Modifier.Object
// Column(temp_modifier) -> Column(Modifier.applyTestTag(tag))

// val tmp_modifier: Modifier = {
// val tmp: Modifier.Object = Modifier.Object
// tmp.fillMaxSize() -> Modifier.applyTestTag(tag).then(tmp.fillMaxSize())
// }
// Column(tmp_modifier) -> Column(tmp_modifier)

// val tmp_modifier: Modifier = Modifier.applyTestTag(tag).fillMaxSize()
// Column(temp_modifier) -> Column(tmp_modifier)

return when (argumentExpression) {
is IrGetValue -> modifyIrGetValue(argumentExpression, parameter, tag, applyTagFunction)
is IrCall -> modifyIrCall(argumentExpression, parameter, tag, applyTagFunction)
is IrGetObjectValue -> modifierIrObject(argumentExpression, parameter, applyTagFunction, tag)
is IrGetObjectValue -> modifierIrGetObject(argumentExpression, parameter, applyTagFunction, tag)
else -> null
}

Expand Down Expand Up @@ -157,25 +175,24 @@ internal class TestTagApplier(
type = modifierObjectClass.defaultType,
symbol = modifierObjectClass
)
modifyExpressionForTestTag(parameter, modifierObject, tag, applyTagFunction)
modifierIrGetObject(modifierObject, parameter, applyTagFunction, tag)
}

variableInitializer is IrBlock -> {
val lastStatement = variableInitializer.statements.lastOrNull() as? IrExpression
if (lastStatement != null) {
val modifiedStatement =
modifyExpressionForTestTag(parameter, lastStatement, tag, applyTagFunction)
modifyExpressionForTestTag(lastStatement, parameter, applyTagFunction, tag)
if (modifiedStatement != null) {
val lastIndex = variableInitializer.statements.lastIndex
variableInitializer.statements[lastIndex] = modifiedStatement
variableInitializer.statements[variableInitializer.statements.lastIndex] = modifiedStatement
}
}
null
}

variableInitializer != null -> {
val modifierInitializer =
modifyExpressionForTestTag(parameter, variableInitializer, tag, applyTagFunction)
modifyExpressionForTestTag(variableInitializer, parameter, applyTagFunction, tag)
if (modifierInitializer != null) {
variable.initializer = modifierInitializer
}
Expand All @@ -185,7 +202,7 @@ internal class TestTagApplier(
}
}

private fun modifierIrObject(
private fun modifierIrGetObject(
argumentExpression: IrExpression,
parameter: IrValueParameter,
applyTagFunction: IrSimpleFunctionSymbol,
Expand All @@ -212,22 +229,37 @@ internal class TestTagApplier(
tag: String,
applyTagFunction: IrSimpleFunctionSymbol
): IrExpression? {

val topmostReceiverCall = argumentExpression.getTopmostReceiverCall()
val topmostReceiverObject =
topmostReceiverCall.extensionReceiver ?: topmostReceiverCall.dispatchReceiver
val topmostReceiverObject = topmostReceiverCall.extensionReceiver ?: topmostReceiverCall.dispatchReceiver

if (topmostReceiverObject is IrGetValue) {
return modifyExpressionForTestTag(
return modifyExpressionChainForIrGetValue(
argumentExpression,
parameter,
topmostReceiverObject,
applyTagFunction,
tag,
applyTagFunction
topmostReceiverObject
)
}

val modifierObjectClass = modifierObjectClass
return modifyExpressionChain(argumentExpression, parameter, applyTagFunction, tag, topmostReceiverObject)
}

private fun modifyExpressionChain(
argumentExpression: IrCall,
parameter: IrValueParameter,
applyTagFunction: IrSimpleFunctionSymbol,
tag: String,
topmostReceiverObject: IrExpression?
): IrCallImpl? {

if (topmostReceiverObject?.type?.isComposeModifierObject() != true) return null

val thenFunction = thenFunction
if (topmostReceiverObject?.type?.isComposeModifierObject() != true || modifierObjectClass == null || thenFunction == null) return null
val modifierObjectClass = modifierObjectClass

if (thenFunction == null || modifierObjectClass == null) return null

val modifierObject = IrGetObjectValueImpl(
startOffset = UNDEFINED_OFFSET,
Expand All @@ -248,7 +280,7 @@ internal class TestTagApplier(
putValueArgument(0, tag.toIrConst(pluginContext.irBuiltIns.stringType))
}

val thenCall = IrCallImpl(
return IrCallImpl(
startOffset = UNDEFINED_OFFSET,
endOffset = UNDEFINED_OFFSET,
type = parameter.type,
Expand All @@ -259,8 +291,37 @@ internal class TestTagApplier(
dispatchReceiver = applyTagCall
putValueArgument(0, argumentExpression)
}
}

private fun modifyExpressionChainForIrGetValue(
argumentExpression: IrCall,
parameter: IrValueParameter,
applyTagFunction: IrSimpleFunctionSymbol,
tag: String,
topmostReceiverObject: IrGetValue
): IrCallImpl? {

val thenFunction = thenFunction
val topExpression = modifyIrGetValue(
topmostReceiverObject,
parameter,
tag,
applyTagFunction
)

return thenCall
if (thenFunction == null || topExpression == null) return null

return IrCallImpl(
startOffset = UNDEFINED_OFFSET,
endOffset = UNDEFINED_OFFSET,
type = parameter.type,
symbol = thenFunction,
typeArgumentsCount = 0,
valueArgumentsCount = 1,
).apply {
dispatchReceiver = topExpression
putValueArgument(0, argumentExpression)
}
}

private fun IrCall.getTopmostReceiverCall(): IrCall =
Expand Down Expand Up @@ -335,7 +396,9 @@ internal class TestTagApplier(
Name.identifier("then")
)
val testTagRegex = "applyTestTag|testTag".toRegex()
val applyTagCallableId =
CallableId(FqName("com.vk.compose.test.tag.applier"), Name.identifier("applyTestTag"))
val applyTagCallableId = CallableId(
FqName("com.vk.compose.test.tag.applier"),
Name.identifier("applyTestTag")
)
}
}
}

0 comments on commit ffda833

Please sign in to comment.