Mood System Bug Fixes & Slight Refactor #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug surrounding the neutral threshold (50) being added twice in `SetMood`, resulting in 100 mood for everyone. Fixes the `NetMoodComponent` field `CurrentMoodLevel` not being synced properly with `MoodComponent`. This also refactors `MoodSystem` to centralize mood calculations to `RefreshMood` and `SetMood`. For consistency reasons, death is now a moodlet that gets added upon death, and removed upon revival. Only `RefreshMood` should ever get to call `SetMood`. I have more ideas on refactoring `MoodSystem` in separate PRs.
…stein-Engines into mood-slight-refactor
VMSolidus
pushed a commit
that referenced
this pull request
Oct 14, 2024
Fix MouseRotator on rotated grids (#29663)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug surrounding the neutral threshold (50) being added twice in
SetMood, resulting in 100 mood for everyone.Fixes the
NetMoodComponentfieldCurrentMoodLevelnot being synced properly withMoodComponent.This also refactors
MoodSystemto centralize mood calculations toRefreshMoodandSetMood.For consistency reasons and due to the above refactor, death is now a moodlet that gets added upon death, and removed upon revival. Only
RefreshMoodshould ever get to callSetMood.I have more ideas on refactoring
MoodSystemin separate PRs.This PR is for this PR: Simple-Station#620