Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6 unused headerFields & remove logic to unshortUrl #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#6 unused headerFields & remove logic to unshortUrl #15

wants to merge 2 commits into from

Conversation

naushad-madakiya
Copy link

  • remove logic to remove unshortUrl as Jsoup does it internally
  • use content.url for original URL & content.finalUrl for final URL after redirection
  • update sample with an example for unshort URL with youtube URL

Issue: #6

Naushad Madakiya added 2 commits August 10, 2019 18:33
fix: remove unused headerFiled & unshort url related code
3702473 
- Jsoup handles the redirection
- remove code related to unshorten url
- use content.url for actual url & content.finalUrl for final url after redirection
- use empty string instead of null check when parsign meta tags

Signed-off-by: Naushad Madakiya <naushad.madakiya@gmail.com>
ui: update sample with more example
6e314d3 
- add short url of youtube
- update UI with new section for youtube url
- aligh texts to left instead of center
- make title bold and url italic

Signed-off-by: Naushad Madakiya <naushad.madakiya@gmail.com>
@naushad-madakiya
Copy link
Author

@pawlo2102 can someone look into the open PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afollestad afollestad afollestad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naushad-madakiya @afollestad