Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gcc + #88

Merged
merged 7 commits into from
Oct 11, 2024
Merged

Upgrade gcc + #88

merged 7 commits into from
Oct 11, 2024

Conversation

joewragg
Copy link

@joewragg joewragg commented Oct 4, 2024

Use trixie as builder and upgrade gcc from trixie for runner

Copy link
Contributor

@jcoupey jcoupey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build failed for some reason, not sure it is related to the change here?

Dockerfile Outdated Show resolved Hide resolved
@jcoupey
Copy link
Contributor

jcoupey commented Oct 7, 2024

The build is OK but then the test script fails here:

eval $status_request > /dev/null
if [[ $? != 0 ]]; then
echo $'ERROR: Couldnt start service.'
cleanup
exit 1
fi

@joewragg joewragg changed the title change base image to get later version of gcc change base image to get later version of gcc + Oct 7, 2024
@joewragg
Copy link
Author

joewragg commented Oct 7, 2024

I think the issue was due to line endings I've pushed a gitattributes to fix line endings to LF for all users

edit: seeing some dynamic library runtime issues

@joewragg
Copy link
Author

joewragg commented Oct 7, 2024

Just pushed a fix but it means that we are manually installing node into the debian-trixie runner image which isn't ideal at all

@joewragg
Copy link
Author

joewragg commented Oct 8, 2024

OK latest push is to install the required packages from trixie instead

@joewragg joewragg force-pushed the bugfix/gcc branch 3 times, most recently from bcff0a5 to 1665414 Compare October 8, 2024 08:25
@joewragg joewragg changed the title change base image to get later version of gcc + Upgrade gcc + Oct 8, 2024
@joewragg
Copy link
Author

Any chance we can get this merged? @jcoupey

.gitattributes Outdated Show resolved Hide resolved
This reverts commit ea448b3.
@jcoupey jcoupey merged commit 201fd5d into VROOM-Project:master Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants