Skip to content

Commit

Permalink
Merge pull request #1862 from VWS-Python/fix-scipy-errors
Browse files Browse the repository at this point in the history
Limit scipy version to avoid errors
  • Loading branch information
adamtheturtle authored Jan 21, 2024
2 parents 2bb5023 + 1bc81e8 commit bb161af
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
3 changes: 2 additions & 1 deletion lint.mk
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ fix-ruff:

.PHONY: pip-extra-reqs
pip-extra-reqs:
pip-extra-reqs --skip-incompatible --requirements-file=<(pdm export --pyproject) src/
# Ignore scipy as it is defined to constrain a version.
pip-extra-reqs --ignore-requirement=scipy --skip-incompatible --requirements-file=<(pdm export --pyproject) src/

.PHONY: pip-missing-reqs
pip-missing-reqs:
Expand Down
5 changes: 3 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -313,14 +313,15 @@ dependencies = [
"pydantic-settings",
"requests",
"requests-mock",
"scipy<1.12.0", # We pin to an old version of scipy as brisque does not support newer versions. `brisque` appears to be unmaintained, so we may need to switch to an alternative, such as `piq`, which currently does not support Python 3.12.
'tzdata; sys_platform == "win32"',
"vws-auth-tools",
]
[project.optional-dependencies]
dev = [
"check-manifest==0.49",
"dirty-equals==0.7.1.post0", # We pin to an old doc8 to avoid version conflicts with sphinx_toolbox. When we bump this, we can remove doc8.ini.
"doc8==0.11.2",
"dirty-equals==0.7.1.post0",
"doc8==0.11.2", # We pin to an old doc8 to avoid version conflicts with sphinx_toolbox. When we bump this, we can remove doc8.ini.
"docker==7.0.0",
"dodgy==0.2.1",
"enum-tools[sphinx]==0.11",
Expand Down

0 comments on commit bb161af

Please sign in to comment.