Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create test folder with a demo html page + webpack config #64

Open
malinbranduse opened this issue Mar 17, 2018 · 3 comments
Open

Create test folder with a demo html page + webpack config #64

malinbranduse opened this issue Mar 17, 2018 · 3 comments

Comments

@malinbranduse
Copy link
Contributor

This could be useful for contributors to test any changes (manually for now) inside the repo, not having to use an external environment.
This folder should be in .npmignore.

Automated testing I think is out of the scope of this project since it's more of a wrapper plugin for Browsersync.
Perhaps some unit tests for the css emissions check?

@Va1
Copy link
Owner

Va1 commented Mar 17, 2018

test/demo folder is nice idea! i might work on this in near future.

i am not sure of how can this be unit-tested though

@malinbranduse
Copy link
Contributor Author

@Va1 It's fine, I think I'll do it, just wrote it down as an issue so we won't forget 😁
About unit testing, I've seen some other plugins do tests, even intergration tests directly running webpack so it might be possible, but I have to do some deeper checks.

@Va1
Copy link
Owner

Va1 commented Mar 17, 2018

@malinushj yeah, i did tests for webpack stuff as part of other package developed by me. but i am not sure i understand what we can cover in this package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants