Pull request for StartRecording file #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Classes that throw exceptions in their constructors are vulnerable to finalizer attacks and thus the exception is removed from StartRecording file #11
Removed unused field TAG from the file as it affects the performance
|
Vaibhav2399
pushed a commit
that referenced
this pull request
Apr 6, 2024
Rename variable to match naming convention. Closes #19
Vaibhav2399
pushed a commit
that referenced
this pull request
Apr 6, 2024
Revert "#2 Merging this if statement with the enclosing one"
Vaibhav2399
pushed a commit
that referenced
this pull request
Apr 6, 2024
Vaibhav2399
pushed a commit
that referenced
this pull request
Apr 6, 2024
Issue-18 private constructor added
Vaibhav2399
pushed a commit
that referenced
this pull request
Apr 6, 2024
Changed the name of the exception from a generic to a dedicated one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed technical debts from StartRecording file and code is working fine after changes. Below are the issue links for it.
Issue1 : #10
Issue2 : #11