Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added required casting in VoiceAnnouncementManager #20

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Conversation

Vaibhav2399
Copy link
Owner

Added the needed casting

@Vaibhav2399 Vaibhav2399 added Bug Something isn't working Group11 labels Feb 16, 2024
@Vaibhav2399 Vaibhav2399 self-assigned this Feb 16, 2024
I removed the extra comments from the file
@Vaibhav2399 Vaibhav2399 changed the title Vaibhav's Technical Debt #1 solved Vaibhav's Technical Debts Changes Feb 16, 2024
@Vaibhav2399 Vaibhav2399 changed the title Vaibhav's Technical Debts Changes Added required casting in VoiceAnnouncementManager Feb 16, 2024
@Vaibhav2399 Vaibhav2399 reopened this Feb 16, 2024
@Vaibhav2399 Vaibhav2399 merged commit a845272 into main Feb 16, 2024
3 of 8 checks passed
Copy link

sonarcloud bot commented Feb 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Vaibhav2399 pushed a commit that referenced this pull request Apr 6, 2024
Rename altitude_m to altitudeMeter
Vaibhav2399 pushed a commit that referenced this pull request Apr 6, 2024
Merged two if statements into one for better code organization and readability.
Vaibhav2399 pushed a commit that referenced this pull request Apr 6, 2024
#20)

Calling Thread.interrupt() ensures that the thread will be interrupted
when InterruptedException is caught and will not risk delaying the
thread shutdown or lose the information that the thread was interrupted.

Code Changes:


![image](https://github.com/rilling/OpenTracks-Winter-SOEN-6431_2024/assets/41756221/aa502709-65c7-4301-bf2d-995eb87b144f)
Vaibhav2399 pushed a commit that referenced this pull request Apr 6, 2024
Vaibhav2399 pushed a commit that referenced this pull request Apr 6, 2024
Added a Lambda function to improve code Performance. #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Group11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant