Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #9

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Dev #9

merged 2 commits into from
Feb 16, 2024

Conversation

DP8801
Copy link
Collaborator

@DP8801 DP8801 commented Feb 15, 2024

This pull request aims to resolve the technical debt

Link to the the issue

  1. Dev's Technical Debt #2 · Issue #8 · Vaibhav2399/OpenTracks-Winter-SOEN-6431_2024 (github.com)

  2. Dev's Technical Debt #1 · Issue #7 · Vaibhav2399/OpenTracks-Winter-SOEN-6431_2024 (github.com)

License agreement
By opening this pull request, you are providing your contribution under the Apache License 2.0 (see LICENSE.md).

Note: new dependencies/libraries
Please refrain from introducing new libraries without consulting the team.

Copy link

sonarcloud bot commented Feb 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@chauhan9674 chauhan9674 added this to the Case Study 1 milestone Feb 16, 2024
@DP8801 DP8801 merged commit d110326 into main Feb 16, 2024
3 of 6 checks passed
Vaibhav2399 pushed a commit that referenced this pull request Apr 6, 2024
Refactoring the Variable Name to Standard Naming Practices - Issue #9
Vaibhav2399 pushed a commit that referenced this pull request Apr 6, 2024
Vaibhav2399 pushed a commit that referenced this pull request Apr 6, 2024
Fix issue #9 to improve Reliability and remove Technical Debt
Vaibhav2399 pushed a commit that referenced this pull request Apr 6, 2024
Vaibhav2399 pushed a commit that referenced this pull request Apr 6, 2024
Renamed record method to create
Vaibhav2399 pushed a commit that referenced this pull request Apr 6, 2024
…not-match-a-restricted-identifier

#9 Renamed record method
Vaibhav2399 pushed a commit that referenced this pull request Apr 6, 2024
Issue#2 Refactored the public class to protected class
Vaibhav2399 pushed a commit that referenced this pull request Apr 6, 2024
This PR consists of changes for issues resolved by Group9.


[#1](tarekFerdous#1)
Define a constant instead of duplicating this literal "<open>1</open>" 3
times.

[#2](tarekFerdous#2)
Replace this usage of 'Stream.collect(Collectors.toList())' with
'Stream.toList()' Group 09

[#6](tarekFerdous#6)
Either re-interrupt this method or rethrow the "InterruptedException"
that can be caught here.

[#9](tarekFerdous#9)
Remove unused "TAG" private field.

[#11](tarekFerdous#11)
Use isEmpty() to check whether the collection is empty or not.

[#13](tarekFerdous#13)
Fixing technical debts for io/file/impoter/importService.java and
io/file/importer/importViewModel.java

[#14](tarekFerdous#14)
io/file/importer/KmlTrackImporter and io/file/importer/KmzTrackImporter

[#15](tarekFerdous#15)
Removing the Deprecated lines in the code Group(09)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants