[Bugfix] Fix bug where sidebar was not taking all available space wit…

…h minHeight set
VanOns · Jul 30, 2019 · 9888383 · 9888383
1 parent 11089b7
commit 9888383
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/src/resources/js/lib/configure-editor.js b/src/resources/js/lib/configure-editor.js
@@ -57,10 +57,11 @@ function disableWPBlocks () {
  */
 function setMaxHeight (maxHeight) {
   const editor = window.Laraberg.editor
-  const editPostLayout = editor.querySelector('.edit-post-layout__content')
-
   editor.style.maxHeight = maxHeight
-  editPostLayout.style.maxHeight = `calc(${maxHeight} - 56px)`
+
+  elementRendered('.edit-post-layout__content', (el) => {
+    el.style.minHeight = `calc(${maxHeight} - 56px)`
+  })
 }
 
 /**
@@ -69,9 +70,11 @@ function setMaxHeight (maxHeight) {
  */
 function setMinHeight (minHeight) {
   const editor = window.Laraberg.editor
-  const sidebar = editor.querySelector('.edit-post-sidebar')
   editor.style.minHeight = minHeight
-  sidebar.style.minHeight = `calc(${minHeight} - 56px)`
+
+  elementRendered('.edit-post-sidebar', (el) => {
+    el.style.minHeight = `calc(${minHeight} - 56px)`
+  })
 }
 
 /**

diff --git a/src/resources/scss/wordpress-overrides.scss b/src/resources/scss/wordpress-overrides.scss
@@ -45,10 +45,6 @@
       padding-top: 0;
     }
   }
-
-  // .block-editor__container {
-  //   position: static;
-  // }
 }
 
 .gutenberg__editor.fixed-height {