Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dye_update and_:outdated_clothes #430

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

NPC1314
Copy link

@NPC1314 NPC1314 commented Jan 3, 2025

About The Pull Request

The dye bins had the partially unfinished version, ports the final version. What this means is

  • cheap and luxury dye set items added
  • cheap one can be made by combos of dirt/ash and jacksberry/swampweed easily
  • crafting dye bins with menu crafts replaced with just crafting a bin normally (or use existing one) and add the dye to it.
    Slapcraft! Its nicer visually, get audio and message feedback and less clutter.
  • Tailor spawns with a luxury dye kit and a advice book reminiding about how it works. This is old style and probably can be yeeted in the near future but got some value for transition period.
  • Few of the color defines updated to latest version, a couple minor hueshifts
  • Merchant can import the luxury dye, tailor spawns with it, thats it.

Logic is simple. Better to have a base item recipe (bin, wich exists) then manipulate it in various ways to create subtypes (make it a water bin by filling with water etc) instead of having each be a separate craft item.

dyebin_alt.mp4

The climb up well item item gets a rope sprite, fits the desc and how it functions bettet than another well sprite in the underground. Sorta like hanging chain in visual style but a rope.

Fancy hats craft recipe 1 cloth cheaper but requires 1 feather. All of them got a feather in the hat, its pretty annoying its not a part of making them.

Found couple more outdated clothes sprites.

-Webbed shirt - the slightly more transparent version added (your current has too high alpha and shows up too close to the normal white one. Basically a little more transparency is all, just enough to make it visually distinct from white regular shirt.
-Shalal wasnt using the color palette adjusted version thus too dark, correct version in.
-Brimmed hat had about 25& pure black area on the onmob, slightly hueshifted that part to dark-dark brown looks nicer
-Flat hat lacked onmob, got it now
-one of the rag masks lacked a toggled icon, sorted.
-noble boots was lacking some states for dwarfs

  • shirts-ass file is obsolete, already merged into shirt, yeeted.

Only thing anyone is likely to even notice of those is the shalal being less super-dark on default color.

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

@NPC1314 NPC1314 changed the title Last_couple_outdated_clothes Couple_more_outdated_clothes Jan 3, 2025
@NPC1314 NPC1314 changed the title Couple_more_outdated_clothes Dye_update and_:outdated_clothes Jan 3, 2025
@NPC1314
Copy link
Author

NPC1314 commented Jan 7, 2025

Ok so if you intend to merge it let me know and I´ll update it. If not just close it, solving bunch of new sprite merge conflicts after 5 days is not very productive use of time unless I know it wont just happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant