-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Gradle #53
Open
manuelprinz
wants to merge
18
commits into
VaughnVernon:master
Choose a base branch
from
manuelprinz:upgrade-gradle
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Upgrade Gradle #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hype! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @VaughnVernon, thank you for your great book! I come back to it regularly, and get something helpful out of it every time!
Lately, I wanted to browse the code to check the implementation of some of the example, and noticed that IDEA is refusing to even index the project because the tooling (specifically Gradle) it too old. So I took some time to get that up-to-date again. I hope you find these contribution valuable, and could apply them to the project, so that it can stay useful and relevant to the DDD community.
This should also close the issues #9, #11, #46 (partially), and #47 (not tested, but likely). It also makes PRs #43 and #31 obsolete.
Noteworthy changes:
There is more that could be done with regards to managing the versions (like Gradle version catalogs) or resolving conflicts. If you are interested in those changes, please let me know. I would be happy to work on that.
Regarding the Docker setup, the use of TestContainers would be nice, to not rely on "external" infrastructures. But I have not even tried that, because most likely all other dependencies would need to be upgraded as well.
If you would like me to split the changes, I can of course do that. I verified that all tests are green, and the project build when running from different Java versions.
Best, Manuel