Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor collect.py further, add simple test #15

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Refactor collect.py further, add simple test #15

merged 4 commits into from
Mar 25, 2024

Conversation

amrit110
Copy link
Member

PR Type

[Feature | Fix | Documentation | Other() ]
Refactor

Short Description

  • Improve collect.py
  • Add simple test to get started with tests generally for the repo

Tests Added

  • tests/data/test_collect.py

@amrit110 amrit110 requested a review from mahshidaln March 22, 2024 14:55
@amrit110 amrit110 self-assigned this Mar 22, 2024
@amrit110 amrit110 added the refactor Refactor existing code label Mar 22, 2024
@amrit110 amrit110 merged commit 85e8d5d into main Mar 25, 2024
1 check failed
@amrit110 amrit110 deleted the refactor_collect branch March 25, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahshidaln mahshidaln mahshidaln approved these changes

Assignees

@amrit110 amrit110

Labels
refactor Refactor existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrit110 @mahshidaln