Added an ignore list for bad rules. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously broken rules (those who referenced invalid fields) where rejected with a warning. But there were so many rejected rules that it was difficult to see when new rules were accidentally rejected when syncing new rule sets. This PR: 1. Adds an ignore list to the rules so bad rules which are already known are not emitting errors any more. 2. Uses a data dump from provider manifests to add trivial field mappings (where the field mapping is simply the EventData field). This helps with maintaining the field mapping for rules using this trivial field mapping. This should make it easier to sync new rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously broken rules (those who referenced invalid fields) where rejected with a warning. But there were so many rejected rules that it was difficult to see when new rules were accidentally rejected when syncing new rule sets.
This PR:
This should make it easier to sync new rules.