Keep better track of rejected rules. #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR writes rejected rules into a file and checks against this file each compile. This allows us to review for new rules that fail using git diff and supporess error messages for rules which are already known to be broken. This PR also returns a failed error code when an unhandled error occurs which allows it to be effective in CI now. Additionally this PR also started adding some VQL based sigma rules for example checking for presence of files or registry keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR writes rejected rules into a file and checks against this file each compile. This allows us to review for new rules that fail using git diff and supporess error messages for rules which are already known to be broken.
This PR also returns a failed error code when an unhandled error occurs which allows it to be effective in CI now.
Additionally this PR also started adding some VQL based sigma rules for example checking for presence of files or registry keys.