Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds certificate ID File flags for provisioning in VCert CLI #490

Merged
merged 3 commits into from
May 28, 2024
Merged

Adds certificate ID File flags for provisioning in VCert CLI #490

merged 3 commits into from
May 28, 2024

Conversation

luispresuelVenafi
Copy link
Contributor

No description provided.

rvelaVenafi
rvelaVenafi approved these changes May 28, 2024
View reviewed changes
README-CLI-CLOUD.md Show resolved Hide resolved
rvelaVenafi
rvelaVenafi requested changes May 28, 2024
View reviewed changes
Copy link
Contributor

@rvelaVenafi rvelaVenafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes needed

sbanic-venafi
sbanic-venafi reviewed May 28, 2024
View reviewed changes
cmd/vcert/cmdCloudKeystores.go Outdated Show resolved Hide resolved
cmd/vcert/validators.go Show resolved Hide resolved
@luispresuelVenafi luispresuelVenafi merged commit 1b471ab into master May 28, 2024
3 checks passed
@luispresuelVenafi luispresuelVenafi deleted the VC-32826-provision-vcert-cli-4 branch May 28, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbanic-venafi sbanic-venafi sbanic-venafi approved these changes

@marcos-albornoz marcos-albornoz marcos-albornoz approved these changes

@rvelaVenafi rvelaVenafi rvelaVenafi approved these changes

@tr1ck3r tr1ck3r Awaiting requested review from tr1ck3r tr1ck3r is a code owner

@EduardoVV EduardoVV Awaiting requested review from EduardoVV EduardoVV is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luispresuelVenafi @rvelaVenafi @marcos-albornoz @sbanic-venafi