Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Graph if there are no files #28

Closed
Villy-P opened this issue Oct 29, 2024 · 3 comments · Fixed by #35
Closed

Fix Graph if there are no files #28

Villy-P opened this issue Oct 29, 2024 · 3 comments · Fixed by #35
Labels
bug Something isn't working

Comments

@Villy-P
Copy link
Owner

Villy-P commented Oct 29, 2024

In the Webview, if there are no files, the graph.

Steps to reproduce the behavior:

  1. Go to an empty directory
  2. Open File Makeup Viewer

Instead, It should display something like "There are no files that match your query"

image
@Villy-P Villy-P added the bug Something isn't working label Oct 29, 2024
@Villy-P Villy-P changed the title Fix Graph if there are no filse Fix Graph if there are no files Oct 30, 2024
@NguyenNguyen205
Copy link
Contributor

Hi, I want to make a little contribution. I've fix this bug, but I don't know if the fix is inline with the desired behavior, so I record a little demo, if you think it's good, then I can make a pull request. I didn't implement FileDeleteEvent from VS Code API for the solution, and only use basic condition checking.

fix_graph_bug_demo.mp4

@Villy-P
Copy link
Owner Author

Villy-P commented Nov 7, 2024

This looks great! If you could also hide the dropdown menu if there are no directories, that would be great, so it only has the Header and the "No files were found" message. Thank you very much!

@NguyenNguyen205 NguyenNguyen205 mentioned this issue Nov 8, 2024
Merged
@NguyenNguyen205
Copy link
Contributor

Hi, sorry for the late reply. Just create a pull request, can you help me review it ?

@Villy-P Villy-P linked a pull request Nov 8, 2024 that will close this issue
Fix no file in directory bug #35
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix no file in directory bug NguyenNguyen205/File-Makeup-Viewer
2 participants
@NguyenNguyen205 @Villy-P