Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix video responsiveness on level 1, 2 and 3 #151

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

Raj100
Copy link
Contributor

@Raj100 Raj100 commented Oct 28, 2024

Merge Request to solve issue #143

  • fixed the video too small issue by adding a media query by changing only the flex direction
  • Does Not effect the current web design

Screenshots:
Screenshot 2024-10-29 at 1 05 11 AM

Screenshot 2024-10-29 at 12 55 38 AM Screenshot 2024-10-29 at 1 05 56 AM

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @Raj100 for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

@Raj100
Copy link
Contributor Author

Raj100 commented Oct 28, 2024

Please add hacktoberfest accepted and ggsoc labels Thank You!😊

@Raj100
Copy link
Contributor Author

Raj100 commented Oct 29, 2024

@Vinay-Khanagavi

@Vinay-Khanagavi
Copy link
Owner

Vinay-Khanagavi commented Oct 29, 2024

Please Update your branch..
Make sure it's up to date

There is bug here which has been resolved but in your code it isn't :
image

@Vinay-Khanagavi Vinay-Khanagavi added the Changes required Pull request is not good enough label Oct 29, 2024
@Raj100
Copy link
Contributor Author

Raj100 commented Oct 30, 2024

I have checked the code is up to date with the current main branch. And the merge request will only affect 3 files

main/level_1/phishing_animated_video.html
main/level_2/phishing_animated_video.html
main/level_3/phishing_animated_video.html

No other files will be affected if fix was made on some other file

@Raj100
Copy link
Contributor Author

Raj100 commented Oct 30, 2024

Screenshot 2024-10-30 at 5 45 48 AM

The issue is still present on the main branch itself its not resolved and this files does not effect to this issue.

@Raj100
Copy link
Contributor Author

Raj100 commented Oct 30, 2024

The integrity code for may be bootstrap or some library is present without proper tag in this file.
https://github.com/Vinay-Khanagavi/Cyberbear.github.io/blob/main/main/level_1/save_game.html
Line no. 13

@Raj100
Copy link
Contributor Author

Raj100 commented Oct 30, 2024

Same true for other levels
Screenshot 2024-10-30 at 5 55 44 AM

@Vinay-Khanagavi
Copy link
Owner

Vinay-Khanagavi commented Oct 30, 2024

Because of accepting un reviewed PR made that happen, correct it and update The PR, I'll merge it.
Your changes are approved for this issue thanks for contributing

@Raj100
Copy link
Contributor Author

Raj100 commented Oct 31, 2024

Accept this Pr for that issue I will create other issue and PR

@Vinay-Khanagavi Vinay-Khanagavi merged commit a5a0061 into Vinay-Khanagavi:main Oct 31, 2024
2 checks passed
@Raj100
Copy link
Contributor Author

Raj100 commented Oct 31, 2024

Please add labels hacktober accepted and ggsoc ext labels

@Raj100
Copy link
Contributor Author

Raj100 commented Oct 31, 2024

@Vinay-Khanagavi Please add hacktober accepted and ggsoc ext labels

@Raj100
Copy link
Contributor Author

Raj100 commented Oct 31, 2024

Please add hacktober accepted and ggsoc ext labels

@Raj100
Copy link
Contributor Author

Raj100 commented Oct 31, 2024

@Vinay-Khanagavi

@Vinay-Khanagavi Vinay-Khanagavi added gssoc-ext GSSoC'24 Extended Version level2 25 Points 🥈 hacktoberfest Hacktober Collaboration hacktoberfest-accepted Hacktoberfest 2024 labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes required Pull request is not good enough gssoc-ext GSSoC'24 Extended Version hacktoberfest Hacktober Collaboration hacktoberfest-accepted Hacktoberfest 2024 level2 25 Points 🥈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants