Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release #21

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Release #21

merged 2 commits into from
Mar 26, 2024

Conversation

gurdeep330
Copy link
Member

Description

2 major updates:

  1. New text for the overview page of the website
  2. Updated S2 id for an article

Fixes # (issue) #13

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Existing tests
  • No new tests added

Checklist:

  • My code follows the style guidelines mentioned in the code management policies
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation/MkDocs
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

lilijap and others added 2 commits March 25, 2024 09:22
@lilijap
Feat update text on the overview page (#15)
bb2d060 
close  #13

* chore: update info on simulator module on the overview page

* chore: include the names of the other tabs in the overview text
@gurdeep330 @lilijap
S2 ID of an article had changed (#20)
1a3b513 
* wrt #1

* Update manually_curated_articles.tsv

add extra categories to curated list

* add --cache clear for pytests

* add new test file

* WRT feat #7; add batch processing of S2 articles

* close #7 #9

* close #7 #9; add tests

* fix: s2 id of a manually curated article

---------

Co-authored-by: lilijap <43205236+lilijap@users.noreply.github.com>
@gurdeep330 gurdeep330 added bug Something isn't working enhancement New feature or request labels Mar 25, 2024
@gurdeep330 gurdeep330 requested a review from lilijap March 25, 2024 13:34
@gurdeep330 gurdeep330 self-assigned this Mar 25, 2024
@gurdeep330
Copy link
Member Author

@lilijap , remember to start the commit message with "feat: "...

@gurdeep330 gurdeep330 changed the title Develop Release Mar 25, 2024
@lilijap lilijap merged commit 1bb935d into main Mar 26, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 26, 2024
@semantic-release-bot
chore(release): 1.3.0 [skip ci]
757faf5 
# [1.3.0](v1.2.3...v1.3.0) (2024-03-26)

### Features

* merge pull request [#21](#21) from VirtualPatientEngine/develop ([1bb935d](1bb935d))
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilijap lilijap Awaiting requested review from lilijap

Assignees

@gurdeep330 gurdeep330

Labels
bug Something isn't working enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gurdeep330 @lilijap