Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #47 #50

Merged

Conversation

gurdeep330
Copy link
Member

@gurdeep330 gurdeep330 commented Aug 8, 2024

For authors

Description

So far Semantics Scholar has allowed only up to 10 positive and 10 negative articles to run their recommendation API. As an example, we have come up with more than 2 topics with each topic containing at least 5 manually curated articles. As per the last codebase, we select all articles under a topic as positive articles and randomly select 10 articles from the remaining articles as negatives, ensuring that number of negative articles from each of the remaining topics is equal (whenever possible). This works for most cases except when the total number of negative articles is less than 10 (e.g.: Issue #47).

Semantics Scholar has now removed the restrictions on the number of positive and negative articles. Users can now have as many positive and negative articles as they wish. The same is now being updated in the current commit. All articles for a given topic are considered as positive (unless the Use column is set to 0). All the articles from the remaining topics are considered as negatives (so long as they are not included as positives).

Fixes # (issue) #47

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests you conducted to verify your changes. These may involve creating new test scripts or updating existing ones.

  • Added new test(s) in the tests folder
  • Added new function(s) to an existing test(s) (e.g.: tests/testX.py)
  • No new tests added (an existing function was updated)

Checklist

  • My code follows the style guidelines mentioned in the Code/DevOps guides
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. MkDocs)
  • My changes generate no new warnings
  • I have added or updated tests (in the tests folder) that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

For reviewers

Checklist pre-approval

  • Is there enough documentation?
  • If a new feature has been added, or a bug fixed, has a test been added to confirm good behavior?
  • Does the test(s) successfully test edge/corner cases?
  • Does the PR pass the tests? (if the repository has continuous integration)

Checklist post-approval

  • Does this PR merge develop into main? If so, please make sure to add a prefix (feat/fix/chore) and/or a suffix BREAKING CHANGE (if it's a major release) to your commit message.
  • Does this PR close an issue? If so, please make sure to descriptively close this issue when the PR is merged.

Checklist post-merge

  • When you approve of the PR, merge and close it (Read this article to know about different merge methods on GitHub)
  • Did this PR merge develop into main and is it suppose to run an automated release workflow (if applicable)? If so, please make sure to check under the "Actions" tab to see if the workflow has been initiated, and return later to verify that it has completed successfully.

@gurdeep330 gurdeep330 added bug Something isn't working enhancement New feature or request labels Aug 8, 2024
@gurdeep330 gurdeep330 self-assigned this Aug 8, 2024
@gurdeep330 gurdeep330 requested review from lilijap and awmulyadi August 8, 2024 11:48
@awmulyadi awmulyadi merged commit e46bfe3 into VirtualPatientEngine:develop Aug 21, 2024
6 checks passed
Copy link
Contributor

github-actions bot commented Sep 5, 2024

🎉 This PR is included in version 3.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants