Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For authors
Description
So far Semantics Scholar has allowed only up to 10 positive and 10 negative articles to run their recommendation API. As an example, we have come up with more than 2 topics with each topic containing at least 5 manually curated articles. As per the last codebase, we select all articles under a topic as positive articles and randomly select 10 articles from the remaining articles as negatives, ensuring that number of negative articles from each of the remaining topics is equal (whenever possible). This works for most cases except when the total number of negative articles is less than 10 (e.g.: Issue #47).
Semantics Scholar has now removed the restrictions on the number of positive and negative articles. Users can now have as many positive and negative articles as they wish. The same is now being updated in the current commit. All articles for a given topic are considered as positive (unless the
Use
column is set to 0). All the articles from the remaining topics are considered as negatives (so long as they are not included as positives).Fixes # (issue) #47
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests you conducted to verify your changes. These may involve creating new test scripts or updating existing ones.
tests
foldertests/testX.py
)Checklist
tests
folder) that prove my fix is effective or that my feature worksFor reviewers
Checklist pre-approval
Checklist post-approval
develop
intomain
? If so, please make sure to add a prefix (feat/fix/chore) and/or a suffix BREAKING CHANGE (if it's a major release) to your commit message.Checklist post-merge
develop
intomain
and is it suppose to run an automated release workflow (if applicable)? If so, please make sure to check under the "Actions" tab to see if the workflow has been initiated, and return later to verify that it has completed successfully.