Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch broke display of results #2486

Open
egonw opened this issue Apr 25, 2024 · 2 comments
Open

Patch broke display of results #2486

egonw opened this issue Apr 25, 2024 · 2 comments
Assignees
Labels
bug something wrong on our end

Comments

@egonw
Copy link
Collaborator

egonw commented Apr 25, 2024

Describe the bug
The patch ac6df96 has a side effect that for https://scholia.toolforge.org/work/Q22236188 it no longer shows supported statements (last panel).

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://scholia.toolforge.org/work/Q22236188
  2. Scroll down to 'Supports the following statement(s)'
  3. Notice no results are shown

Expected behavior
2000 (the query max) rows should be shown.

Screenshots

image

Additional context
I think I isolated the problem in the patch being the BIND in this part:

?statement ?a1 ?value1 ; ?a2 ?value2 . BIND (COALESCE(?value1, ?value2) AS ?value)

Without the BIND all results show up, but with the BIND they do not.

@egonw egonw added the bug something wrong on our end label Apr 25, 2024
@egonw
Copy link
Collaborator Author

egonw commented Apr 25, 2024

I cannot find what that patch was fixing :( The branches around the patch do not seem to contain the patch (gitk screenshot):

image

Ah, that is done with this CLI command:

git branch --contains ac6df96df2ea3ac46e48b73c794c5726bf0a9bbd

@egonw
Copy link
Collaborator Author

egonw commented Apr 25, 2024

I am really sorry about the uninformative, default commit message. That is not really helpful, and not like me.

@fnielsen, I propose to revert the patch (two actually). I will eventually discover the problem again. I guess it was related with one of the PRs that got merged in shortly before that. Do you agree? (If so, I will make the PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something wrong on our end
Projects
None yet
Development

No branches or pull requests

2 participants