Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make strings non-nullable and be more explicit about number types #120

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

alice
Copy link
Member

@alice alice commented Jun 1, 2018

Re-opening this - frustratingly there is no "undo" for a merge, just a git revert.

See #118 for earlier discussion.

@cookiecrook @minorninth let's discuss more here.

@alice
Copy link
Member Author

alice commented Jun 1, 2018

Copying @cookiecrook's comment over:


@alice wrote:

@cookiecrook PTAL?

I don't understand why this is being worked on in the AOM incubator instead of in an ARIA issue? I made all the ARIA DOMStrings nullable b/c they reflect both the values of defined attributes and nullable undefined attributes. Doubles and longs cannot be nullable, which is why those were DOMStrings.

Most of the other changes are because of the findings mentioned in another comment on ARIA #691, so I'd really prefer to address these concerns on the ARIA repo.

Perhaps the AOM incubation file should include it by reference instead and limit the new IDL scope to something like:

ShadowRoot includes AriaAttributes;

As well as any object reference extensions we'd need. E.g.

interface mixin AriaElementReferences {
    // ariaLabelledByElements, etc.
}

@alice
Copy link
Member Author

alice commented Jun 1, 2018

I don't understand why this is being worked on in the AOM incubator instead of in an ARIA issue?

Simply that we can keep the discussion smaller here and come to a consensus before we take it to the ARIA group - if you'd prefer to go directly to the ARIA discussion, though, I'm happy to do that instead.

(...) Doubles and longs cannot be nullable, which is why those were DOMStrings.

I based this change off Dominic's comment:

From: https://w3c.github.io/aria/#state_property_processing

Sometimes states and properties are present in the DOM but have a zero-length string ("") as their value. This is equivalent to their absence. User agents SHOULD treat state and property attributes with a value of "" the same as they treat an absent attribute.

It sounds like we don't need these to be nullable DOMStrings, then, for that reason.

It sounds like you disagree with this logic?

Perhaps the AOM incubation file should include it by reference instead and limit the new IDL scope to something like (...)

I think most of these things will end up having a permanent "home" somewhere else, so I think it's reasonable to group them together here for readability while we work on the details. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant