Skip to content

Commit

Permalink
Re-add fenced frame config internal container size. (#187)
Browse files Browse the repository at this point in the history
Follow-up to #182

Along with the unused IDL size attributes, I also removed the internal fenced frame config container size definition. I was mistaken about it being vestigial (I missed a reference to it in the implementation when I was originally deciding to remove it, so I didn't see it was actively used). 

The Protected Audience spec depended on the field, and I broke their build: WICG/turtledove#1270 (comment)

This change re-adds the container size definition to un-break things.
  • Loading branch information
VergeA authored Sep 5, 2024
1 parent a8ec772 commit ecf159c
Showing 1 changed file with 12 additions and 3 deletions.
15 changes: 12 additions & 3 deletions spec.bs
Original file line number Diff line number Diff line change
Expand Up @@ -725,9 +725,9 @@ boundary, which can allow for colluding parties to join cross-site data and buil
user. To prevent that, the ad auction API [=construct a pending fenced frame config|constructs=] a
[=fenced frame config=] whose underlying [=fenced frame config/mapped url|URL=] is opaque to the
embedding context. The [=fenced frame config=] is also constructed with restrictions on what the
[=fenced frame config/content size=] of the frame must be and what the [=fenced frame config/
effective enabled permissions|permissions policy=] of the frame must be, as those can be used as
fingerprinting vectors.
[=fenced frame config/container size=] and [=fenced frame config/content size=] of the frame must
be and what the [=fenced frame config/effective enabled permissions|permissions policy=] of the
frame must be, as those can be used as fingerprinting vectors.

Displaying a personalized payment button:

Expand Down Expand Up @@ -1127,6 +1127,9 @@ A <dfn export>fenced frame config</dfn> is a [=struct=] with the following [=str
: <dfn for="mapped url">visibility</dfn>
:: a [=fencedframeconfig/visibility=]

: <dfn>container size</dfn>
:: null, or a [=fencedframetype/size=]

: <dfn>content size</dfn>
:: null, or a [=struct=] with the following [=struct/items=]:
: <dfn for="content size">value</dfn>
Expand Down Expand Up @@ -1223,6 +1226,9 @@ A <dfn export>fenced frame config instance</dfn> is a [=struct=] with the follow
: <dfn>mapped url</dfn>
:: a [=URL=]

: <dfn>container size</dfn>
:: null, or a [=fencedframetype/size=]

: <dfn>content size</dfn>
:: null, or a [=fencedframetype/size=]

Expand Down Expand Up @@ -1268,6 +1274,9 @@ A <dfn export>fenced frame config instance</dfn> is a [=struct=] with the follow
: [=fenced frame config instance/mapped url=]
:: |config|'s [=fenced frame config/mapped url=]'s [=mapped url/value=]

: [=fenced frame config instance/container size=]
:: |config|'s [=fenced frame config/container size=]

: [=fenced frame config instance/content size=]
:: |config|'s [=fenced frame config/content size=] if null, otherwise |config|'s [=fenced frame
config/content size=]'s [=content size/value=]
Expand Down

0 comments on commit ecf159c

Please sign in to comment.