Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec] Have navigate algorithm be able to take in a FencedFrameConfig IDL object. #194

Open
blu25 opened this issue Oct 3, 2024 · 0 comments

Comments

@blu25
Copy link
Collaborator

blu25 commented Oct 3, 2024

Currently, per spec, if an config-generating API generates a FencedFrameConfig, and the embedder of a fenced frame or even the fenced frame itself "guesses" the urn:uuid backing it, it could navigate the fenced frame to that config.

This doesn't match implementations, and is bad because the intention of a FencedFrameConfig IDL object is to allow only the embedder to navigate the fenced frame with the config object. We should modify the navigation algorithm monkeypatches to be able to accept a FencedFrameConfig object, and only check the fenced frame config mapping if a FencedFrameConfig is supplied to the algorithm, as opposed to if a urn is supplied.

See this comment thread: #183 (comment)

@domfarolino domfarolino changed the title [Spec] Have navigate patch be able to take in a FencedFrameConfig IDL object. [Spec] Have navigate algorithm be able to take in a FencedFrameConfig IDL object. Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant