Skip to content

Commit

Permalink
Apply feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
Maks Orlovich committed Oct 17, 2024
1 parent 4397e9e commit 8f89dde
Showing 1 changed file with 9 additions and 10 deletions.
19 changes: 9 additions & 10 deletions spec.bs
Original file line number Diff line number Diff line change
Expand Up @@ -1977,7 +1977,7 @@ and a [=real time reporting contributions map=] |realTimeContributionsMap|:
1. [=Apply any component ads target to a bid=] given |generatedBid|.
1. [=list/Append=] |generatedBid| to |bidsToScore|.
1. [=Register bids for forDebuggingOnly reports=] given |bidsToScore|, |ig|,
|bidDebugReportInfo|, and |reportingContextMap| [|auctionConfig|].
|bidDebugReportInfo|, and |reportingContextMap|[|auctionConfig|].
1. If |auctionConfig|'s [=auction config/per buyer real time reporting config=][|buyer|]
is "`default-local-reporting`", then [=insert entries to map=] given
|realTimeContributionsMap|, |buyer|, and |realTimeContributions|.
Expand Down Expand Up @@ -2228,8 +2228,7 @@ or "component-auction", a [=currency tag=] |componentAuctionExpectedCurrency|, a
contributions); as it would be problematic to report a winner that didn't actually win.

1. If |reportingContext|'s [=reporting context/debug reporting info=][|generatedBid|'s [=generated
bid/reporting id=]] does not exist, set [=reporting context/debug reporting info=][
|generatedBid|'s [=generated bid/reporting id=]] to a new [=bid debug reporting info=].
bid/reporting id=]] does not [=map/exist=], set it to a new [=bid debug reporting info=].
1. Let |bidDebugReportInfo| be |reportingContext|'s [=reporting context/debug reporting info=]
[|generatedBid|'s [=generated bid/reporting id=]].
1. If |auctionLevel| is "top-level-auction":
Expand All @@ -2254,7 +2253,7 @@ or "component-auction", a [=currency tag=] |componentAuctionExpectedCurrency|, a
["{{ScoreAdOutput/allowComponentAuction}}"] is false;
* |scoreAdOutput|["{{ScoreAdOutput/desirability}}"] ≤ 0.
1. If |auctionLevel| is "component-auction":
1. Set |generatedBid|'s [=generated bid/component seller=] to |seller|
1. Set |generatedBid|'s [=generated bid/component seller=] to |seller|.
1. Let |bidToCheck| be |generatedBid|'s [=generated bid/bid=].
1. If |scoreAdOutput|["{{ScoreAdOutput/bid}}"] [=map/exists=]:
1. Let |modifiedBidValue| be |scoreAdOutput|["{{ScoreAdOutput/bid}}"].
Expand Down Expand Up @@ -3389,7 +3388,7 @@ The <dfn for=Navigator method>getInterestGroupAdAuctionData(|configIDL|)</dfn> m

## Common types and algorithms ## {#reporting-common}

A <dfn>reporting bid source</dfn> an enum with the following possible values:
A <dfn>reporting bid source</dfn> is an enum with the following possible values:
<dl dfn-for="reporting bid source">
: <dfn>`generate-bid`</dfn>
:: Bid produced by an invocation of `generateBid()`.
Expand All @@ -3402,8 +3401,8 @@ A <dfn>reporting bid source</dfn> an enum with the following possible values:

A <dfn>reporting bid key</dfn> is a [=struct=] with the following [=struct/items=]:

Note: This type exists only to uniquely identify places bids came from, avoiding confusion in
cases like bids made by the same interest group in different component auctions, or additional
Note: This [=struct=] exists only to uniquely identify places bids came from, avoiding confusion
in cases like bids made by the same interest group in different component auctions, or additional
bids reusing names of regular interest groups. Implementations can likely find a more efficient
way of achieving the same effect. Note that bids returned when `generateBid()` returns multiple
items all share a key, as they share reporting information, too.
Expand All @@ -3421,7 +3420,7 @@ A <dfn>reporting bid key</dfn> is a [=struct=] with the following [=struct/items
context.
</dl>

A <dfn>reporting context</dfn> is a struct with the following [=struct/items=]:
A <dfn>reporting context</dfn> is a [=struct=] with the following [=struct/items=]:
<dl dfn-for="reporting context">
: <dfn>debug reporting info</dfn>
:: A [=map=] from [=reporting bid key=] to [=bid debug reporting info=].
Expand Down Expand Up @@ -4102,8 +4101,8 @@ a [=reporting context map=] |reportingContextMap|, an [=auction config=] |auctio
: [=reporting bid key/origin=]
:: |ig|'s [=interest group/owner=]
: [=reporting bid key/bid identifier=]
:: A string representation of a new globably unique identifier. This is needed since |igName|
may not be unique.
:: A [=string=] representation of a new globably unique identifier. This is needed since
|igName| may not be unique.
: [=generated bid/bid=]
:: A [=bid with currency=] whose [=bid with currency/value=] is |bidVal|, and
[=bid with currency/currency=] is |bidCurrency|
Expand Down

0 comments on commit 8f89dde

Please sign in to comment.