From 8f89dde28d22344926761d6dc568a0ac4f763457 Mon Sep 17 00:00:00 2001 From: Maks Orlovich Date: Thu, 17 Oct 2024 11:14:46 -0400 Subject: [PATCH] Apply feedback --- spec.bs | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/spec.bs b/spec.bs index 9ca7ee8d..bae68027 100644 --- a/spec.bs +++ b/spec.bs @@ -1977,7 +1977,7 @@ and a [=real time reporting contributions map=] |realTimeContributionsMap|: 1. [=Apply any component ads target to a bid=] given |generatedBid|. 1. [=list/Append=] |generatedBid| to |bidsToScore|. 1. [=Register bids for forDebuggingOnly reports=] given |bidsToScore|, |ig|, - |bidDebugReportInfo|, and |reportingContextMap| [|auctionConfig|]. + |bidDebugReportInfo|, and |reportingContextMap|[|auctionConfig|]. 1. If |auctionConfig|'s [=auction config/per buyer real time reporting config=][|buyer|] is "`default-local-reporting`", then [=insert entries to map=] given |realTimeContributionsMap|, |buyer|, and |realTimeContributions|. @@ -2228,8 +2228,7 @@ or "component-auction", a [=currency tag=] |componentAuctionExpectedCurrency|, a contributions); as it would be problematic to report a winner that didn't actually win. 1. If |reportingContext|'s [=reporting context/debug reporting info=][|generatedBid|'s [=generated - bid/reporting id=]] does not exist, set [=reporting context/debug reporting info=][ - |generatedBid|'s [=generated bid/reporting id=]] to a new [=bid debug reporting info=]. + bid/reporting id=]] does not [=map/exist=], set it to a new [=bid debug reporting info=]. 1. Let |bidDebugReportInfo| be |reportingContext|'s [=reporting context/debug reporting info=] [|generatedBid|'s [=generated bid/reporting id=]]. 1. If |auctionLevel| is "top-level-auction": @@ -2254,7 +2253,7 @@ or "component-auction", a [=currency tag=] |componentAuctionExpectedCurrency|, a ["{{ScoreAdOutput/allowComponentAuction}}"] is false; * |scoreAdOutput|["{{ScoreAdOutput/desirability}}"] ≤ 0. 1. If |auctionLevel| is "component-auction": - 1. Set |generatedBid|'s [=generated bid/component seller=] to |seller| + 1. Set |generatedBid|'s [=generated bid/component seller=] to |seller|. 1. Let |bidToCheck| be |generatedBid|'s [=generated bid/bid=]. 1. If |scoreAdOutput|["{{ScoreAdOutput/bid}}"] [=map/exists=]: 1. Let |modifiedBidValue| be |scoreAdOutput|["{{ScoreAdOutput/bid}}"]. @@ -3389,7 +3388,7 @@ The getInterestGroupAdAuctionData(|configIDL|) m ## Common types and algorithms ## {#reporting-common} -A reporting bid source an enum with the following possible values: +A reporting bid source is an enum with the following possible values:
: `generate-bid` :: Bid produced by an invocation of `generateBid()`. @@ -3402,8 +3401,8 @@ A reporting bid source an enum with the following possible values: A reporting bid key is a [=struct=] with the following [=struct/items=]: - Note: This type exists only to uniquely identify places bids came from, avoiding confusion in - cases like bids made by the same interest group in different component auctions, or additional + Note: This [=struct=] exists only to uniquely identify places bids came from, avoiding confusion + in cases like bids made by the same interest group in different component auctions, or additional bids reusing names of regular interest groups. Implementations can likely find a more efficient way of achieving the same effect. Note that bids returned when `generateBid()` returns multiple items all share a key, as they share reporting information, too. @@ -3421,7 +3420,7 @@ A reporting bid key is a [=struct=] with the following [=struct/items context.
-A reporting context is a struct with the following [=struct/items=]: +A reporting context is a [=struct=] with the following [=struct/items=]:
: debug reporting info :: A [=map=] from [=reporting bid key=] to [=bid debug reporting info=]. @@ -4102,8 +4101,8 @@ a [=reporting context map=] |reportingContextMap|, an [=auction config=] |auctio : [=reporting bid key/origin=] :: |ig|'s [=interest group/owner=] : [=reporting bid key/bid identifier=] - :: A string representation of a new globably unique identifier. This is needed since |igName| - may not be unique. + :: A [=string=] representation of a new globably unique identifier. This is needed since + |igName| may not be unique. : [=generated bid/bid=] :: A [=bid with currency=] whose [=bid with currency/value=] is |bidVal|, and [=bid with currency/currency=] is |bidCurrency|