-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spec] Add basic B&A response handling #1260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some initial comments.
Co-authored-by: qingxinwu <6334674+qingxinwu@users.noreply.github.com>
…ove into BAresponseHandling
the build error should have been fixed in WICG/fenced-frame#187, no need to worry about it. I'll follow up on that if that commit does not fix the build error. |
Co-authored-by: qingxinwu <6334674+qingxinwu@users.noreply.github.com>
Co-authored-by: qingxinwu <6334674+qingxinwu@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving considering there's a follow up PR waiting to be uploaded which would fill in this PR's many small TODOs.
SHA: fde4556 Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: fde4556 Reason: push, by brusshamilton Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: fde4556 Reason: push, by qingxinwu Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Preview | Diff