Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spec] Handle reporting id from B&A server response #1281

Merged
merged 5 commits into from
Sep 23, 2024
Merged

[Spec] Handle reporting id from B&A server response #1281

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c93d801
in-progress
Sep 20, 2024
e55e339
Merge branch 'main' into reportingid
qingxinwu Sep 23, 2024
a38dd09
almost done, with one question.
Sep 23, 2024
2f6fb90
finish
Sep 23, 2024
bbd9584
clearer document
Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2800,13 +2800,14 @@ a [=list=] of [=interest groups=] |bidIgs|, and a [=list=] of [=bid debug report
1. If |winningGroup|'s [=interest group/ads=] is null, then return failure.
1. Let |winningAd| be null.
1. [=list/For each=] |ad| of |winningGroup|'s [=interest group/ads=]:
1. If |response|'s [=server auction response/ad render url=] is |ad|'s [=interest group ad/render url=], then set
|winningAd| to |ad|, and [=iteration/break=].
1. If |winningAd| is null, then return failure.

Issue: TODO: Check that the buyerReportingId and buyerAndSellerReportingId from the
server response match that in the |winningAd|.
(<a href="https://github.com/WICG/turtledove/issues/1254">WICG/turtledove#1254</a>)
1. If |response|'s [=server auction response/ad render url=] is |ad|'s
[=interest group ad/render url=], then set |winningAd| to |ad|, and [=iteration/break=].
1. Return failure if any of the following conditions hold:
* |winningAd| is null;
* |response|'s [=server auction response/buyer and seller reporting id=] is not null and not
|winningAd|'s [=interest group ad/buyer and seller reporting ID=];
* |response|'s [=server auction response/buyer reporting id=] is not null and not
|winningAd|'s [=interest group ad/buyer reporting ID=].
1. Let |winningAdDescriptor| be a new [=ad descriptor=] whose [=ad descriptor/url=] is
|response|'s [=server auction response/ad render url=].
1. Let |winningAdComponents| be a new [=list=] of [=ad descriptors=].
Expand Down Expand Up @@ -3080,10 +3081,12 @@ from an auction executed on the trusted auction server. It has the following [=s
: <dfn>ad metadata</dfn>
:: Null or a JSON [=string=]. Null when the server auction is not a component auction.
Otherwise the value contains the component auction's winning bid's [=generated bid/ad=].
: buyer reporting id
:: TODO.
: buyer and seller reporting id
:: TODO.
: <dfn>buyer reporting id</dfn>
:: Null or a [=string=]. When not null, this will be verified with the winning bid's
[=generated bid/ad=]'s [=interest group ad/buyer reporting ID=].
: <dfn>buyer and seller reporting id</dfn>
:: Null or a [=string=]. When not null, this will be verified with the winning bid's
[=generated bid/ad=]'s [=interest group ad/buyer and seller reporting ID=].
: error
:: Null or [=string=]. When not null, contains an error message from the
auction executed on the trusted auction server. May be used to provide
Expand Down
Loading