-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch key for B&A request #1289
Merged
Merged
Changes from 19 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
8341eed
Add payload optimization
brusshamilton b71d3bf
Add missing =
brusshamilton 301c989
Add constraint on request size
brusshamilton 861c1f3
Add key fetch
brusshamilton b2825f3
Move key lookup to parallel queue
brusshamilton 6d02ea3
Apply suggestions from code review
brusshamilton 593aa6e
Apply suggestions from code review
brusshamilton cd1c21c
Address comments
brusshamilton aa50ea5
Address comments
brusshamilton 54e8bfd
Add domintro for AdAuctionDataConfig
brusshamilton 930b98a
Fix missing description
brusshamilton 6a9eaf9
Apply suggestions from code review
brusshamilton 91e9f95
Describe values of {{AdAuctionDataConfig/perBuyerConfig}}
brusshamilton 23cd2c6
Fix filtering logic
brusshamilton ff4b625
rephrase
brusshamilton 32a17c8
Merge remote-tracking branch 'upstream/main' into fetchKey
brusshamilton d38c4f7
Address comments
brusshamilton 935b5f8
rephrase and add key id
brusshamilton a7e1b5d
capitalize ID
brusshamilton 0fd1270
rephrase
brusshamilton dabe1f8
Apply suggestions from code review
brusshamilton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3195,6 +3195,23 @@ The <dfn for=Navigator method>getInterestGroupAdAuctionData(|configIDL|)</dfn> m | |
1. Let |p| be [=a new promise=]. | ||
1. Let |queue| be the result of [=starting a new parallel queue=]. | ||
1. [=parallel queue/enqueue steps|Enqueue the following steps=] to |queue|: | ||
1. If |config|'s [=auction data config/coordinator=] is not one of the [=implementation-defined=] | ||
coordinators supported by this [=user agent=]: | ||
1. [=Queue a global task=] on the [=DOM manipulation task source=], given |global|, to | ||
[=reject=] |p| with a {{TypeError}}. | ||
1. Abort these steps. | ||
1. Let |key|,|key id| be a [=byte sequence=] containing one of the [[RFC9180|HPKE]] public | ||
encryption keys for |config|'s [=auction data config/seller=] and its | ||
corresponding key ID as determined by |config|'s | ||
[=auction data config/coordinator=], or failure if no key is | ||
available. The actual method for this lookup is [=implementation-defined=], | ||
and may consist of fetching the keys from a known [=URL=]. | ||
1. If |key| is failure then: | ||
1. [=Queue a global task=] on the [=DOM manipulation task source=], given |global|, to | ||
[=reject=] |p| with a {{TypeError}}. | ||
1. Abort these steps. | ||
1. Set |config|'s [=auction data config/encryption key=] to |key|. | ||
1. Set |config|'s [=auction data config/encryption key id=] to |key id|. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |keyId| There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
1. Let |igMap| be a new [=map=] whose [=map/keys=] are [=origins=] and [=map/values=] are [=lists=]. | ||
1. Let |startTime| be a [=moment=] equal to the [=current wall time=]. | ||
1. [=list/For each=] |ig| of the [=user agent=]'s [=interest group set=]: | ||
|
@@ -7657,6 +7674,11 @@ An <dfn>auction data config</dfn> is a [=struct=] with the following [=struct/it | |
: <dfn>coordinator</dfn> | ||
:: The origin of the coordinator hosting public encryption keys for the server | ||
running the ad auction. The [=origin/scheme=] must be "`https`". | ||
: <dfn>encryption key</dfn> | ||
brusshamilton marked this conversation as resolved.
Show resolved
Hide resolved
|
||
:: A [=byte sequence=]. The public [[RFC9180|HPKE]] encryption key to be used | ||
to encrypt the request. | ||
: <dfn>encryption key id</dfn> | ||
:: An {{octet}} containing the key ID corresponding to the [=auction data config/encryption key=]. | ||
: <dfn>request size</dfn> | ||
:: {{unsigned long}} or null. An optional field, containing the desired size | ||
for the returned encrypted request blob. | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems broken. Key is a [=byte sequence=], not (|key|, |keyId|). Need to rewrite it a little bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrased (pulled out to a function).