[Spec] Add publisher to ad auction data config #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingxinwu
reviewed
Oct 1, 2024
|
|
||
| 1. Let |seller| be the result of running [=parse an https origin=] on | ||
| |configIDL|["{{AdAuctionDataConfig/seller}}"]. | ||
| 1. Let |coordinator| be the result of running [=parse an https origin=] on | ||
| |configIDL|["{{AdAuctionDataConfig/coordinatorOrigin}}"]. | ||
| 1. If |seller| or |coordinator| are failure, then [=exception/throw=] a {{TypeError}}. | ||
| 1. Let |config| be a new [=auction data config=] with the following [=struct/items=]: | ||
| : [=auction data config/publisher=] | ||
| :: |top_level_origin| | ||
| : [=auction data config/seller=] | ||
| :: |seller| |
There was a problem hiding this comment.
the IETF's algorithm does not take a seller in its inputs. Is there a problem of passing seller to that algorithm? If not, I think it would be fine, otherwise, need to move this out from [=auction data config=].
There was a problem hiding this comment.
I think it's fine.
Co-authored-by: qingxinwu <6334674+qingxinwu@users.noreply.github.com>
qingxinwu
approved these changes
Oct 1, 2024
github-actions bot
added a commit
that referenced
this pull request
Oct 1, 2024
SHA: 840355a Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to morlovich/turtledove
that referenced
this pull request
Oct 4, 2024
SHA: 840355a Reason: push, by morlovich Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff