Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spec] Add publisher to ad auction data config #1291

Merged
merged 2 commits into from
Oct 1, 2024
+11 −2
Merged

[Spec] Add publisher to ad auction data config #1291

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1533c4e
Add publisher to ad auction data config
brusshamilton Oct 1, 2024
28d1e5c
Apply suggestions from code review
brusshamilton Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3191,7 +3191,10 @@ The <dfn for=Navigator method>getInterestGroupAdAuctionData(|configIDL|)</dfn> m
1. Let |global| be [=this=]'s [=relevant global object=].
1. If |global|'s [=associated Document=] is not [=allowed to use=] the "[=run-ad-auction=]"
[=policy-controlled feature=], then [=exception/throw=] a "{{NotAllowedError}}" {{DOMException}}.
1. Let |config| be the result of running [=parse and verify ad auction data config=] on |configIDL|.
1. Let |settings| be |global|'s [=relevant settings object=].
brusshamilton marked this conversation as resolved.
Show resolved Hide resolved
1. Let |topLevelOrigin| be |settings|'s [=environment/top-level origin=].
1. Let |config| be the result of running [=parse and verify ad auction data config=]
on |configIDL| and |topLevelOrigin|.
brusshamilton marked this conversation as resolved.
Show resolved Hide resolved
1. Let |p| be [=a new promise=].
1. Let |queue| be the result of [=starting a new parallel queue=].
1. [=parallel queue/enqueue steps|Enqueue the following steps=] to |queue|:
Expand Down Expand Up @@ -3265,14 +3268,17 @@ The <dfn for=Navigator method>getInterestGroupAdAuctionData(|configIDL|)</dfn> m
</div>

<div algorithm>
To <dfn>parse and verify ad auction data config</dfn> given an {{AdAuctionDataConfig}} |configIDL|:
To <dfn>parse and verify ad auction data config</dfn> given an
{{AdAuctionDataConfig}} |configIDL| and [=origin=] |top_level_origin|:

1. Let |seller| be the result of running [=parse an https origin=] on
|configIDL|["{{AdAuctionDataConfig/seller}}"].
1. Let |coordinator| be the result of running [=parse an https origin=] on
|configIDL|["{{AdAuctionDataConfig/coordinatorOrigin}}"].
1. If |seller| or |coordinator| are failure, then [=exception/throw=] a {{TypeError}}.
1. Let |config| be a new [=auction data config=] with the following [=struct/items=]:
: [=auction data config/publisher=]
:: |top_level_origin|
: [=auction data config/seller=]
:: |seller|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the IETF's algorithm does not take a seller in its inputs. Is there a problem of passing seller to that algorithm? If not, I think it would be fine, otherwise, need to move this out from [=auction data config=].

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine.

: [=auction data config/coordinator=]
Expand Down Expand Up @@ -7651,6 +7657,10 @@ for a given [=k-anonymity key=]. These records are stored in the [=user agent=].
An <dfn>auction data config</dfn> is a [=struct=] with the following [=struct/items=]:

<dl dfn-for="auction data config">
: <dfn>publisher</dfn>
:: An [=origin=].
The origin of the top level page running the ad auction. The
[=origin/scheme=] must be "`https`".
: <dfn>seller</dfn>
:: An [=origin=].
The origin of the seller running the ad auction. The [=origin/scheme=] must be "`https`".
Expand Down
Loading