Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: Move over the config/IG code changes from Private Aggregation spec. #1297

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Oct 9, 2024

  1. Move over the config/IG code changes from Private Aggregation spec.

    Right now Private Aggregation monkey patches us a lot to implement
    our integration. This moves over the most mundane of the changes ---
    parsing of new IG and AuctionConfig fields --- to reduce the size of
    the monkeypatch and to practive how the process works.
    
    It's moved basically unchanged (except different indent/wrapping);
    I think the only substantative change is using our origin parser.
    
    https://github.com/morlovich/private-aggregation-api/tree/move-stuff-to-pa
    has the other half, it likely needs something with imports (I hope
    adding export to auction config/interest group on our end will help).
    Maks Orlovich committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    61d0bc2 View commit details
    Browse the repository at this point in the history
  2. Fix field names.

    Maks Orlovich committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    0ebe04d View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Alex feedback.

    Maks Orlovich committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b9ed772 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Apply Qingxin's feedback.

    Maks Orlovich committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    5940593 View commit details
    Browse the repository at this point in the history