[Spec] Fix the abort steps in promise handling #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@morlovich @brusshamilton how about this to make the promise failure handling less ambiguous? |
morlovich
approved these changes
Oct 10, 2024
github-actions bot
added a commit
that referenced
this pull request
Oct 11, 2024
SHA: a5912c0 Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought the "abort these steps" for a component auction only aborted the steps for that component auction. But since all component auctions' steps are added to the same queue (which has a single algorithm queue that all steps are added to and then run in series), so the "abort these steps" may mean abort all component auctions' steps, at least it's ambiguous. It's different from what we wanted it say.
This is just a quick fix to let the algorithm match our intention and be less ambiguous. We may want to change the parallel queue to just "in parallel", or multiple queues, to let component auctions run simultaneously, but that needs further consideration and more care about how to deal race conditions.
Preview | Diff