refactor(AnnotationService): getLatestScoreAnnotation()

[hirokiterashima]

Changes

• Simplify function using Array.filter() and Array.at()
• Function now returns undefined instead of null if there is no latest score or auto-score
• Add private modifiers, param types and function return types
• Update references
• Add basic tests

Test

• Teacher score and auto-score annotations appear correctly as before in
  • Grading by step
  • Grade by team
  • Milestone report -> Student Work
  • Student VLE component scores from teacher and auto-scores from CRater

[geoffreykwan]

Works well.

I'm wondering if getLatestScoreAnnotation() should return null for consistency. There's also a slight difference in behavior between null and undefined.

Calling this
JSON.stringify({a: null, b: undefined})

Returns this
'{"a":null}'

I'm wondering if that will come into play in places like this or similar places.

WISE-Client/src/assets/wise5/components/embedded/embedded-show-work/embedded-show-work.component.ts

Lines 117 to 134 in 5191b41

	const latestScoreAnnotation = this.AnnotationService.getLatestScoreAnnotation(
	this.nodeId,
	this.componentId,
	workgroupId,
	type
	);
	const latestCommentAnnotation = this.AnnotationService.getLatestCommentAnnotation(
	this.nodeId,
	this.componentId,
	workgroupId,
	type
	);
	const message = {
	messageType: 'latestAnnotations',
	latestScoreAnnotation: latestScoreAnnotation,
	latestCommentAnnotation: latestCommentAnnotation
	};
	this.sendMessageToApplication(message);

and

WISE-Client/src/assets/wise5/components/embedded/embedded-student/embedded-student.component.ts

Lines 236 to 253 in 5191b41

	const latestScoreAnnotation = this.AnnotationService.getLatestScoreAnnotation(
	this.nodeId,
	this.componentId,
	workgroupId,
	type
	);
	const latestCommentAnnotation = this.AnnotationService.getLatestCommentAnnotation(
	this.nodeId,
	this.componentId,
	workgroupId,
	type
	);
	const message = {
	messageType: 'latestAnnotations',
	latestScoreAnnotation: latestScoreAnnotation,
	latestCommentAnnotation: latestCommentAnnotation
	};
	this.sendMessageToApplication(message);

[geoffreykwan]

Should this be something like this to be more concise?

    return (
      (scoreType === 'any' && ['autoScore', 'score'].includes(annotation.type)) ||
      annotation.type === scoreType
    );

[geoffreykwan]

Looks good.