Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Classroom Monitor): Null pointer when exiting workgroup grading view #1493

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix(Classroom Monitor): Null pointer when exiting workgroup grading view #1493

merged 1 commit into from
Oct 26, 2023

Conversation

geoffreykwan
Copy link
Member

Changes

Properly filter out null workgroup when changing views.

Test

  1. Open a run in the Classroom Monitor
  2. Go to the Grade by Team view
  3. Click on a team
  4. Go to any other view like Grade by Step or Manage Students
  5. The error below used to show up in the console but now it should not
teacherDataService.ts:683 ERROR TypeError: Cannot read properties of null (reading 'workgroupId')
    at Object.next (student-grading.component.ts:139:48)

Closes #1492

@geoffreykwan geoffreykwan self-assigned this Oct 25, 2023
@geoffreykwan geoffreykwan marked this pull request as ready for review October 25, 2023 19:41
hirokiterashima
hirokiterashima approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoffreykwan geoffreykwan merged commit 8ce19f4 into develop Oct 26, 2023
@geoffreykwan geoffreykwan deleted the issue-1492-null-pointer-moving-away-from-workgroup-grading-view branch October 26, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@geoffreykwan geoffreykwan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(Classroom Monitor): Null pointer error when moving away from workgroup grading view
2 participants
@geoffreykwan @hirokiterashima