Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(TeacherProjectService): Extract CreateComponentService #1911

Merged
merged 3 commits into from
Aug 22, 2024
Merged

refactor(TeacherProjectService): Extract CreateComponentService #1911

merged 3 commits into from
Aug 22, 2024

Conversation

hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Aug 21, 2024 •
edited
Loading

Changes

  • Extract functions related to creating a component from TeacherProjectService.createComponent() to CreateComponentService.create()
  • Refactor addComponentToNode()
  • Add tests
  • Remove unused function TeacherProjectService.removeNodeIdFromInactiveNodes()

Test

  • In the AT, creating new component(s) works as before. Verify that the new component is placed correctly.
    • Add your own node. Try adding multiple components
    • Edit step view. Try adding component at the beginning and after an existing component

@hirokiterashima hirokiterashima added this to the Tech Debt 18 -> 17 milestone Aug 21, 2024
@hirokiterashima hirokiterashima self-assigned this Aug 21, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review August 21, 2024 17:04
geoffreykwan
geoffreykwan approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit f32035e into develop Aug 22, 2024
4 of 5 checks passed
@hirokiterashima hirokiterashima deleted the refactor-teacherProjectService-createComponent branch August 22, 2024 22:53
@hirokiterashima
Copy link
Member Author

🎉 This issue has been resolved in version 5.156.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreykwan geoffreykwan geoffreykwan approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels
Code Quality released
Projects
WISE Development 2023-2024
Status: Done
Milestone
Tech Debt 18 -> 17
Development

Successfully merging this pull request may close these issues.
2 participants
@hirokiterashima @geoffreykwan