Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Canvg): Upgrade to v4.0 #1932

Merged
merged 1 commit into from
Sep 3, 2024
Merged

chore(Canvg): Upgrade to v4.0 #1932

merged 1 commit into from
Sep 3, 2024

Conversation

hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Sep 3, 2024 •
edited
Loading

Changes

  • Upgrade Canvg to v4.0. We use this library to parse SVG when snipping graph to a new note.

Test Prep

  • Run npm install to get upgraded dependencies

Test

  • Snipping a graph to a new note should work as before

@hirokiterashima hirokiterashima self-assigned this Sep 3, 2024
@hirokiterashima hirokiterashima changed the title chore(Canvas): Upgrade to v4.0 chore(Canvg): Upgrade to v4.0 Sep 3, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review September 3, 2024 06:45
geoffreykwan
geoffreykwan approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit 1cf99f9 into develop Sep 3, 2024
4 of 5 checks passed
@hirokiterashima hirokiterashima deleted the upgrade-canvas-to-4.0 branch September 3, 2024 21:03
@hirokiterashima
Copy link
Member Author

🎉 This issue has been resolved in version 5.156.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreykwan geoffreykwan geoffreykwan approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels
build released
Projects
WISE Development 2023-2024
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hirokiterashima @geoffreykwan