Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ProjectService): getAllPaths() #1933

Merged
merged 2 commits into from
Sep 4, 2024
Merged

refactor(ProjectService): getAllPaths() #1933

merged 2 commits into from
Sep 4, 2024

Conversation

hirokiterashima
Copy link
Member

Changes

  • Break down function to getStepPaths() and getLessonPaths(), and clean up getLessonPaths()

Test

  • getAllPaths() works as before. Test functions that call it and ensure that features that rely on it work as before.

@hirokiterashima
refactor(ProjectService): getAllPaths()
f23de42 
Break down function to getStepPaths() and getLessonPaths(), and clean up
getLessonPaths()
@hirokiterashima hirokiterashima added this to the Tech Debt 18 -> 17 milestone Sep 3, 2024
@hirokiterashima hirokiterashima self-assigned this Sep 3, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review September 3, 2024 19:36
geoffreykwan
geoffreykwan approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit 5625d84 into develop Sep 4, 2024
4 of 5 checks passed
@hirokiterashima hirokiterashima deleted the refactor-ProjectService-getAllPaths branch September 4, 2024 15:46
@hirokiterashima
Copy link
Member Author

🎉 This issue has been resolved in version 5.156.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreykwan geoffreykwan geoffreykwan approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels
Code Quality released
Projects
WISE Development 2023-2024
Status: Done
Milestone
Tech Debt 18 -> 17
Development

Successfully merging this pull request may close these issues.
2 participants
@hirokiterashima @geoffreykwan