-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Authoring): Allow adding branch from add step button #1935
Merged
hirokiterashima
merged 114 commits into
develop
from
issue-1745-add-branch-from-add-step-button
Sep 13, 2024
Merged
feat(Authoring): Allow adding branch from add step button #1935
hirokiterashima
merged 114 commits into
develop
from
issue-1745-add-branch-from-add-step-button
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sic-params feat(Authoring): Add branch route with basic params
…ath-parameters feat(Authoring): Add branch show branch path parameters
…mponents refactor(Authoring): Add branch use select components
…mponent refactor(Authoring): Create branch path authoring component
…-component feat(Authoring): Create select merge step component
…e-select-for-choice-chosen feat(Authoring): Use select for choice chosen when authoring branch path
feat(Authoring): Add branch to project
Add step before does not work properly when adding step and importing from another unit, adding an automated assessment, or adding an interactive simulation to the first step in a branch path. Add step before on a merge step does not work properly yet.
…y issue during merge since this behavior works in production
…ia is workgroup id or random
… EditBranchService
…. Clean up AuthorBranchService.createPathStep() to pass through pathIndex to downstream functions instead of pathNumber
…unctions to a new file
…oices. Angular was throwing an error: Expression has changed after it was checked
…BranchComponent. Replace calls to getter with direct variable access
…r EditBranchService.editBranch(). Remove unused return types for submit()
…ks in insertNodeBetweenInGroups()
hirokiterashima
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
breity
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
hirokiterashima
deleted the
issue-1745-add-branch-from-add-step-button
branch
September 13, 2024 17:40
🎉 This issue has been resolved in version 5.157.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Test
Closes #1745