Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Authoring): Allow adding branch from add step button #1935

Merged
merged 114 commits into from
Sep 13, 2024

Conversation

geoffreykwan
Copy link
Member

@geoffreykwan geoffreykwan commented Sep 4, 2024

Changes

  • Added a create branch view
  • Added an edit branch view

Test

  • Make sure you can create a branch
  • Make sure you can edit a branch

Closes #1745

…sic-params

feat(Authoring): Add branch route with basic params
…ath-parameters

feat(Authoring): Add branch show branch path parameters
…mponents

refactor(Authoring): Add branch use select components
…mponent

refactor(Authoring): Create branch path authoring component
…-component

feat(Authoring): Create select merge step component
…e-select-for-choice-chosen

feat(Authoring): Use select for choice chosen when authoring branch path
Add step before does not work properly when adding step and importing
from another unit, adding an automated assessment, or adding an
interactive simulation to the first step in a branch path.

Add step before on a merge step does not work properly yet.
@geoffreykwan geoffreykwan marked this pull request as ready for review September 5, 2024 16:41
hirokiterashima and others added 18 commits September 9, 2024 14:12
…y issue during merge since this behavior works in production
…. Clean up AuthorBranchService.createPathStep() to pass through pathIndex to downstream functions instead of pathNumber
…oices. Angular was throwing an error: Expression has changed after it was checked
…BranchComponent. Replace calls to getter with direct variable access
…r EditBranchService.editBranch(). Remove unused return types for submit()
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@hirokiterashima hirokiterashima merged commit 13dd769 into develop Sep 13, 2024
4 of 5 checks passed
@hirokiterashima hirokiterashima deleted the issue-1745-add-branch-from-add-step-button branch September 13, 2024 17:40
@hirokiterashima
Copy link
Member

🎉 This issue has been resolved in version 5.157.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat(Authoring): Allow adding branch from add step button
3 participants