Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Multilingual Unit): Component content doesn't update when changing language #1937

Conversation

hirokiterashima
Copy link
Member

This broke when we converted Node to standalone. When we started tracking by "component.id" in the for loop, even though the content changed, angular didn't detect the change.

Changes

  • Fix for the above

Test

  • Component content translations should update immediately when switching to another language
  • Single-language units should work as before

Closes #1936

…g language. This broke when we converted Node to standalone
@hirokiterashima hirokiterashima added the bug Something isn't working label Sep 9, 2024
@hirokiterashima hirokiterashima self-assigned this Sep 9, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review September 9, 2024 23:51
@hirokiterashima hirokiterashima merged commit c914c99 into develop Sep 10, 2024
5 checks passed
@hirokiterashima hirokiterashima deleted the issue-1936-bug-component-content-does-not-update-when-switching-language branch September 10, 2024 00:02
@hirokiterashima
Copy link
Member Author

🎉 This issue has been resolved in version 5.156.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bug(Multilingual Unit): Component content doesn't update when changing language
1 participant