Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit icon URL and Chinese filenames not auto-completing URLs. #1940

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

VM8gkAs
Copy link
Contributor

@VM8gkAs VM8gkAs commented Sep 13, 2024

Changes

  1. Updated the setFeaturedProjectIcon method in project-info-authoring.component.ts to correctly construct the unit icon URL.
  2. Modified the regex in projectService.ts to support Chinese characters in filenames.

Test

  • I haven’t had the chance to fully test these changes. Could you please help by verifying the following?
    Thank you!

Pic

  • Attached is a screenshot illustrating the original issue with the incorrect unit icon URL and the URL auto-completion for Chinese filenames.

image

image

@hirokiterashima hirokiterashima self-assigned this Sep 27, 2024
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hirokiterashima hirokiterashima merged commit dd7a9a3 into WISE-Community:develop Sep 27, 2024
1 of 3 checks passed
@VM8gkAs VM8gkAs deleted the patch-1 branch September 27, 2024 05:10
@hirokiterashima
Copy link
Member

🎉 This issue has been resolved in version 5.160.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants