Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(a11y): Add keyboard accessibility to AT unit home #1943

Merged
merged 2 commits into from
Sep 18, 2024
Merged

feat(a11y): Add keyboard accessibility to AT unit home #1943

merged 2 commits into from
Sep 18, 2024

Conversation

breity
Copy link
Member

@breity breity commented Sep 17, 2024

Changes

  • Make all action elements/buttons on Authoring Tool Unit Home lessons and steps are keyboard accessible.
  • Use MatExpansionPanel for lessons.
  • Disable constraint icon click action for steps in a branch path.
  • Change icon color for step action buttons to ensure contrast meets WCAG AA standard.

Test

  • Make sure expand all and collapse all buttons in AT Unit Home work as before.
  • Make sure lessons can still be expanded/collapsed by clicking on lesson.
  • Make sure all action icons on lessons still work as before.
  • Make sure clicking on step still opens step authoring view.
  • Make sure all action icons on steps work as before.
  • Make sure you can use the keyboard to navigate to lessons and steps and all their action icons and the icon buttons work using the keyboard (enter key or space bar for checkboxes).

Closes #1942.

@breity breity self-assigned this Sep 17, 2024
@hirokiterashima hirokiterashima added the enhancement New feature of any size or improvement (UI, performance, security) label Sep 17, 2024
hirokiterashima
hirokiterashima approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/assets/wise5/authoringTool/project-authoring-lesson/project-authoring-lesson.harness.ts Outdated
@@ -5,10 +5,11 @@ import {
ProjectAuthoringNodeHarnessFilters
} from '../project-authoring/project-authoring-node.harness';

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty line?

Suggested change

src/assets/wise5/authoringTool/project-authoring/project-authoring.component.ts Outdated
@@ -33,6 +43,7 @@ export class ProjectAuthoringComponent implements OnInit {
protected lessonIdToExpanded: WritableSignal<{ [key: string]: boolean }> = signal({});
protected nodeIdToChecked: any = {};
protected nodeTypeSelected: Signal<NodeTypeSelected>;
@ViewChild('panel') panel: MatExpansionPanel;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused, remove? Also remove the imports above.

Suggested change
@ViewChild('panel') panel: MatExpansionPanel;

@breity breity merged commit cf21971 into develop Sep 18, 2024
5 checks passed
@breity breity deleted the issue-1942-at-unit-home-add-keyboard-accessibility branch September 18, 2024 20:14
@hirokiterashima
Copy link
Member

🎉 This issue has been resolved in version 5.158.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hirokiterashima hirokiterashima added this to the A11y milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@breity breity

Labels
enhancement New feature of any size or improvement (UI, performance, security) released
Projects
WISE Development 2023-2024
Status: Done
Milestone
A11y
Development

Successfully merging this pull request may close these issues.

feat(a11y): Add keyboard accessibility to AT unit home
2 participants
@breity @hirokiterashima