Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a11y): Add keyboard accessibility to AT node authoring #1950

Merged

Conversation

breity
Copy link
Member

@breity breity commented Sep 19, 2024

Changes

  • Make all action elements/buttons on components in Authoring Tool step (node) authoring are keyboard accessible.
  • Use MatExpansionPanel for components.
  • Move add new component buttons next to components to match lesson and step authoring.

Test

  • Make sure expand all and collapse all buttons in AT node authoring work as before.
  • Make sure components can still be expanded/collapsed by clicking on lesson.
  • Make sure all action icons on components still work as before.
  • Make sure you can use the keyboard to navigate to components and all their action icons and the icon buttons work using the keyboard (enter key or space bar for checkboxes).

Closes #1948.

@breity breity self-assigned this Sep 19, 2024
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I can't select the component checkbox with the spacebar?

Everything else looks good.

@breity
Copy link
Member Author

breity commented Sep 20, 2024

@hirokiterashima Ah, yep. Thanks for catching that. Should be fixed now.

Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hirokiterashima
Copy link
Member

I just noticed an extra padding to the right of the wrench icon in step authoring. I don't see this in production, so I wonder if it was introduced in this PR? If it's easy, can you fix it before merge?
Screenshot 2024-09-20 at 8 11 14 AM

@hirokiterashima hirokiterashima added the enhancement New feature of any size or improvement (UI, performance, security) label Sep 20, 2024
@hirokiterashima hirokiterashima added this to the A11y milestone Sep 20, 2024
@breity breity merged commit 23add31 into develop Sep 20, 2024
4 of 5 checks passed
@breity breity deleted the issue-1948-add-keyboard-acessibility-to-node-authoring branch September 20, 2024 15:45
@hirokiterashima
Copy link
Member

🎉 This issue has been resolved in version 5.159.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature of any size or improvement (UI, performance, security) released
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat(a11y): Add keyboard accessibility to AT node authoring
2 participants