Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(VLEComponent): Convert to standalone #1951

Merged
merged 1 commit into from
Sep 20, 2024
Merged

refactor(VLEComponent): Convert to standalone #1951

merged 1 commit into from
Sep 20, 2024

Conversation

hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Sep 19, 2024 •
edited
Loading

Changes

  • Convert VLEComponent to standalone
  • Clean up code

Test

  • VLE (regular and tabbed) loads and works as before
    • saving/retrieving work
    • saving notes and reports
    • next/prev navigations

@hirokiterashima hirokiterashima added this to the Tech Debt 17 -> 16 milestone Sep 19, 2024
@hirokiterashima hirokiterashima self-assigned this Sep 19, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review September 19, 2024 23:33
breity
breity approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit 81815fe into develop Sep 20, 2024
4 of 5 checks passed
@hirokiterashima hirokiterashima deleted the convert-vleComponent-to-standalone branch September 20, 2024 17:11
@hirokiterashima
Copy link
Member Author

🎉 This issue has been resolved in version 5.160.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breity breity breity approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels
Code Quality Low Priority released
Projects
WISE Development 2023-2024
Status: Done
Milestone
Tech Debt 17 -> 16
Development

Successfully merging this pull request may close these issues.
2 participants
@hirokiterashima @breity