Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(TeacherDataService): Move functions to OneWorkgroupPerRowExport #2004

Merged

Conversation

hirokiterashima
Copy link
Member

Changes

The functions were only used in OneWorkgroupPerRowExport, and didn't need to be in TeacherDataService.

This pull request includes several changes to the OneWorkgroupPerRowDataExportStrategy class in the src/assets/wise5/classroomMonitor/dataExport/strategies/OneWorkgroupPerRowDataExportStrategy.ts file. The changes primarily focus on code formatting for better readability and the addition of a new method to retrieve the latest branch path taken event. Additionally, some redundant methods have been removed from the TeacherDataService class.

Improvements to code readability:

Codebase simplification:

  • Added a new method getLatestBranchPathTakenEvent to the OneWorkgroupPerRowDataExportStrategy class to encapsulate the logic for retrieving the latest branch path taken event.
  • Removed the getLatestEventByWorkgroupIdAndNodeIdAndType and isEventMatchingNodeIdEventType methods from the TeacherDataService class as they are no longer needed.

Test

  • OneWorkgroupPerRow export, with branch path taken.

@hirokiterashima hirokiterashima added this to the Tech Debt 17 -> 16 milestone Nov 26, 2024
@hirokiterashima hirokiterashima self-assigned this Nov 26, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review November 26, 2024 02:00
@hirokiterashima hirokiterashima merged commit 1a10293 into develop Nov 26, 2024
4 of 5 checks passed
@hirokiterashima hirokiterashima deleted the refactor-OneWorkgroupPerRow-get-LatestBranchPathTaken branch November 26, 2024 02:17
@hirokiterashima
Copy link
Member Author

🎉 This issue has been resolved in version 5.163.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant