refactor(TeacherDataService): Move functions to OneWorkgroupPerRowExport #2004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The functions were only used in OneWorkgroupPerRowExport, and didn't need to be in TeacherDataService.
This pull request includes several changes to the
OneWorkgroupPerRowDataExportStrategy
class in thesrc/assets/wise5/classroomMonitor/dataExport/strategies/OneWorkgroupPerRowDataExportStrategy.ts
file. The changes primarily focus on code formatting for better readability and the addition of a new method to retrieve the latest branch path taken event. Additionally, some redundant methods have been removed from theTeacherDataService
class.Improvements to code readability:
Codebase simplification:
getLatestBranchPathTakenEvent
to theOneWorkgroupPerRowDataExportStrategy
class to encapsulate the logic for retrieving the latest branch path taken event.getLatestEventByWorkgroupIdAndNodeIdAndType
andisEventMatchingNodeIdEventType
methods from theTeacherDataService
class as they are no longer needed.Test