refactor(AnnotationService): Simplify getLatestAnnotation logic #2005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request includes several changes to the
AnnotationService
class insrc/assets/wise5/services/annotationService.ts
to improve code consistency and simplify the methodgetLatestAnnotation
. Additionally, a small change was made to theVLEComponent
class insrc/assets/wise5/vle/vle.component.ts
.getLatestAnnotation
is only called via embedded components that use WISEAPI.Code Consistency Improvements:
'use strict';
directive fromannotationService.ts
.AnnotationService
fromConfigService
andProjectService
toconfigService
andprojectService
.configService
andprojectService
) throughoutAnnotationService
. [1] [2] [3] [4]Method Simplification:
getLatestAnnotation
method by removing nested conditionals and using a more concise iteration and matching approach.Minor Change:
getLatestAnnotationForComponent
method inVLEComponent
by directly passing parameters to thegetLatestAnnotation
method ofannotationService
.Test