refactor(ShowNodeInfoDialog): Convert to standalone component #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hirokiterashima
deleted the
convert-ShowNodeInfoDialogComponent-to-standalone
branch
|
🎉 This issue has been resolved in version 5.163.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request includes changes to the
show-node-info-dialogcomponent and its related files to improve modularity and fix import issues. The most important changes include modifying imports, updating component declarations, and adjusting test cases.Import and Dependency Updates:
MatDialogModuleandNodeInfoComponentimports fromshow-node-info-dialog.component.spec.tsand addedShowNodeInfoDialogComponentto the imports instead [1] [2].MatDialogModule,MatButtonModule, andNodeInfoComponentimports toshow-node-info-dialog.component.tsand marked the component as standalone.Component and Module Adjustments:
ShowNodeInfoDialogComponentimport fromclassroom-monitor.module.tsto the correct position and removed unnecessaryNodeInfoComponentimport [1] [2] [3].Test Case Updates:
stepTitleinstead ofcomponent.stepNumberAndTitleinshow-node-info-dialog.component.spec.ts.nodeobject definition inshow-node-info-dialog.component.spec.ts.Test